-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename table #422
Rename table #422
Conversation
Let's not disable travis and fix the tests now, we should be running them on all versions |
Given that it takes time to fix the |
I'm ok with it if we remove the changes to Ember try config, if tests are going to fail anyways we shouldn't mess with the test suite. |
@@ -1,9 +1,25 @@ | |||
The MIT License (MIT) | |||
Copyright © 2017 Addepar, Inc. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This license is the same as the old one:
https://github.com/Addepar/ember-table/blob/addepar/LICENSE.md
Only the year is changed.
Yay, tests pass. I don't why it passes but it passes. Ready for review again |
@@ -13,11 +13,6 @@ cache: | |||
env: | |||
# we recommend new addons test the current and previous LTS | |||
# as well as latest stable release (bonus points to beta/canary) | |||
- EMBER_TRY_SCENARIO=ember-lts-2.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need to revert these changes, and we really should add ember-1.11
too but we can get this merged for now
@pzuraq alright, I added a number of test scenarios in the travis file, including 1.13, 2.8, etc. All of them pass now. 1.11 is failing |
Ah, to fix that just add |
Adding |
Yay, all tests pass including 1.11 |
Rename
ember-table-2
->ember-table