Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename table #422

Merged
merged 13 commits into from
Sep 22, 2017
Merged

Rename table #422

merged 13 commits into from
Sep 22, 2017

Conversation

billy-addepar
Copy link
Contributor

@billy-addepar billy-addepar commented Sep 15, 2017

Rename ember-table-2 -> ember-table

@billy-addepar
Copy link
Contributor Author

@pzuraq

@pzuraq
Copy link
Contributor

pzuraq commented Sep 15, 2017

Let's not disable travis and fix the tests now, we should be running them on all versions

@billy-addepar
Copy link
Contributor Author

Given that it takes time to fix the ember-try and publish Addepar stylegiude, I think we should go ahead and merge this PR.

@pzuraq
Copy link
Contributor

pzuraq commented Sep 18, 2017

I'm ok with it if we remove the changes to Ember try config, if tests are going to fail anyways we shouldn't mess with the test suite.

@@ -1,9 +1,25 @@
The MIT License (MIT)
Copyright © 2017 Addepar, Inc. All Rights Reserved.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This license is the same as the old one:

https://github.com/Addepar/ember-table/blob/addepar/LICENSE.md

Only the year is changed.

@billy-addepar
Copy link
Contributor Author

Yay, tests pass. I don't why it passes but it passes. Ready for review again

@@ -13,11 +13,6 @@ cache:
env:
# we recommend new addons test the current and previous LTS
# as well as latest stable release (bonus points to beta/canary)
- EMBER_TRY_SCENARIO=ember-lts-2.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to revert these changes, and we really should add ember-1.11 too but we can get this merged for now

@billy-addepar
Copy link
Contributor Author

@pzuraq alright, I added a number of test scenarios in the travis file, including 1.13, 2.8, etc. All of them pass now. 1.11 is failing You can only pass attributes (such as name=value) not bare values to a helper for a View found in and I have not figure out how to fix that in test. But at least we have coverage for a number of Ember versions.

@pzuraq
Copy link
Contributor

pzuraq commented Sep 21, 2017

Ah, to fix that just add import 'vertical-collection/-debug'; to test-helper.js

@billy-addepar
Copy link
Contributor Author

Adding import 'vertical-collection/-debug'; does not solve it. I still get the same issue

@billy-addepar
Copy link
Contributor Author

Yay, all tests pass including 1.11

@billy-addepar billy-addepar merged commit e7ce993 into 2.0 Sep 22, 2017
@billy-addepar billy-addepar deleted the billy/rename-table branch September 22, 2017 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants