Header & row action #428
Merged
Header & row action #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
billy-addepar
commented
Oct 4, 2017
billy-addepar
commented
- Adds support for sending action from table header / row.
billy-addepar
commented
Oct 4, 2017
addon/components/ember-table-row.js
Outdated
| const tableObject = this.get('row.api.targetObject'); | ||
| tableObject.send('onRowClicked', event, this.get('rowIndex')); | ||
|
|
||
| this.sendAction('onRowClicked', event, this.get('rowIndex'), this.get('rowValue')); |
There was a problem hiding this comment.
There are 2 actions sent in this case: one for table for row selection. The other is for outer controller
pzuraq
reviewed
Oct 4, 2017
addon/components/ember-table-row.js
Outdated
| const tableObject = this.get('row.api.targetObject'); | ||
| tableObject.send('onRowClicked', event, this.get('rowIndex')); | ||
|
|
||
| this.sendAction('onRowClicked', event, this.get('rowIndex'), this.get('rowValue')); |
There was a problem hiding this comment.
I think onRowClicked here is a bit verbose, from the user standpoint they already know they're passing in actions to the row. Let's do onClick instead
addon/components/ember-table-row.js
Outdated
| } | ||
|
|
||
| doubleClick(event) { | ||
| this.sendAction('onRowDoubleClicked', event, this.get('rowIndex'), this.get('rowValue')); |
pzuraq
reviewed
Oct 4, 2017
addon/components/ember-table-row.js
Outdated
| @@ -77,12 +77,12 @@ export default class EmberTableRow extends Component { | |||
|
|
|||
| click(event) { | |||
| const tableObject = this.get('row.api.targetObject'); | |||
| tableObject.send('onRowClicked', event, this.get('rowIndex')); | |||
| tableObject.send('onClick', event, this.get('rowIndex')); | |||
There was a problem hiding this comment.
This is different because we are not sending this action externally. Really, if the table were using the row component directly, it would look like:
{{#ember-table as |row|}}
{{ember-table-row onClick="onRowClicked"}}
{{/ember-table}}
So this action and the action on the table should remain onRowClicked
pzuraq
approved these changes
Oct 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.