[refactor] Move row meta to CollapseTree #532
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors CollapseTree to take much more of the responsibility
of managing the state of rows, and setting up their meta objects. This
does a few things:
ColumnTree. At some point they could probably be made to extend from
the same base class.
us to fix selection, and add the
grouping
mode)API Changes
ember-tbody
no longer accepts atree
object, it'll only take anarray of rows. To get a single root node in a tree, pass in an array
with a single parent node.
collapsed
->isCollapsed
on nodes to bring it inline withterminology through the repo
selectMode
option:grouping
Both checkboxes and the table itself will be styled to match Addepar's
internal table usage in an upcoming PR.
enableTree
andenableCollapse
on thetbody
.Other Stuff
tbody
Note: There is a subtle memory leak introduced in this PR, would like to fix it before we merge but this one is really tricky. I've narrowed it down to the
onSelect
action, somehow by sending rows up from there we're leaking.