Yield to inverse when tbody rows are empty #608
Conversation
ynotdraw
force-pushed
the
tbody-yield-to-inverse
branch
from
a5c795c to
a7bd2e4
Compare
|
+1 here! this would be great, to expose a "No results" state. |
|
Discussed this with @ynotdraw and I think it's a great feature, definitely want to get it merged! It looks like there's a failure on the oldest Ember version we support. I can try to take a look, but I'm unsure when I'll have time. Once tests are passing there we can merge this. |
|
I'm hoping to have some time this weekend to dig into the changes required to support the oldest Ember version with this PR 👍 |
ynotdraw
force-pushed
the
tbody-yield-to-inverse
branch
2 times, most recently
from
5a954f8 to
4d081d8
Compare
ynotdraw
force-pushed
the
tbody-yield-to-inverse
branch
from
4d081d8 to
17b2f0a
Compare
|
@pzuraq howdy! I had some time to get back to these tests and support for Ember 1.x if you have some time to review! |
|
does it solve #631 or am I misreading the code? |
|
@twokul oh nice - at the time that issue didn't exist, but yup, this PR will take care of allowing |
|
Thanks @twokul <3 |
|
<3 |
One thing I noticed with this implementation is that since the yielded inverse content is rendered inside of the
tbody, the content only spans the width of the first column by default. Any thoughts on the best way to solve this? Should it be wrapped in a row or something?I'm not sure how you wanted to handle documentation either. I could take a stab, if you want to point me in the right area where you think it makes sense (maybe under the
rows-and-treessection? Does it deserve it's own section?).Looks like I may need to do something for Ember 1 as well (SUPPORTS_INVERSE_BLOCK).