Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE] Add 3.4, 3.8 LTS to ember-try #720

Merged
merged 3 commits into from
Jul 16, 2019
Merged

[CHORE] Add 3.4, 3.8 LTS to ember-try #720

merged 3 commits into from
Jul 16, 2019

Conversation

bantic
Copy link
Contributor

@bantic bantic commented Jul 16, 2019

Fixes #719

bantic added 2 commits July 16, 2019 11:25
@bantic
[CHORE] Add 3.4, 3.8 LTS to ember-try
5a09605 
Fixes #719
@bantic
[CHORE] Update .travis.yml
a4cc1cc 
Remove some deprecated config settings for Travis.
Update settings to more closely align with the default addon output,
see https://github.com/ember-cli/ember-addon-output/blob/master/.travis.yml
mixonic
mixonic reviewed Jul 16, 2019
View reviewed changes
.travis.yml
# See https://git.io/vdao3 for details.
- JOBS=1

branches:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the intent with this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It comes from the default travis.yml that is generated by ember addon.

The docs from travis: https://docs.travis-ci.com/user/customizing-the-build/#building-specific-branches
I cannot tell if that means it will avoid building pull-request branches, if so I will remove this setting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently it prevents double-builds for branches pushed by the repo owner, see:
ember-cli/ember-cli@30eab4c

@bantic bantic merged commit 15cf3ae into master Jul 16, 2019
@bantic bantic deleted the bantic/add-ember-try-scenarios branch July 16, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mixonic mixonic mixonic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add 3.4 and 3.8 (LTS) to ember-try config
2 participants
@bantic @mixonic