Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Unconditionally enable faker for dummy app #723

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

bantic
Copy link
Contributor

@bantic bantic commented Jul 16, 2019

The addon-docs /docs site uses faker to generate some of the demo data, so it must be enabled all the time. Normally ember-faker excludes faker from production builds, but our addon-docs deploy process builds the app in the production env, so we must enable it.

@bantic bantic added the docs label Jul 16, 2019
@bantic bantic added this to the Prepare for 2.0 release milestone Jul 16, 2019
@bantic bantic merged commit 74d858f into master Jul 17, 2019
@bantic bantic deleted the bantic/docs/enable-faker branch July 17, 2019 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant