Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Change styling for row-selection demo options #730

Merged
merged 1 commit into from
Jul 19, 2019

Conversation

bantic
Copy link
Contributor

@bantic bantic commented Jul 19, 2019

Change the styling so the interactive row-selection demo
moves the radio button labels to the right of the button, and
add back in some alignment and spacing between the labels.
The docs were using a tailwind CSS class "pr-4" but tailwind is no longer
provided via addon-docs, so those styles were not being applied.

Before
image

After
image

Change the styling so the interactive row-selection demo
moves the radio button labels to the right of the button, and
add back in some alignment and spacing between the labels.
The docs were using a tailwind CSS class "pr-4" but tailwind is no longer
provided via addon-docs, so those styles were not being applied.
@bantic bantic added the docs label Jul 19, 2019
flex-basis: 40%;
}

& > * + * {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬 :mindblown:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given <a><b /><c /></a> this only matches c?

Copy link
Contributor Author

@bantic bantic Jul 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, yeah. It selects "an element that follows an element". I discovered this recently and am probably over-using it... :) It's a cleaner alternative to using 2 rules: 1 rule that sets some padding and then another that targets ":first-child" or ":last-child" to remove the padding.

https://alistapart.com/article/axiomatic-css-and-lobotomized-owls/

@bantic bantic merged commit 5c8643d into master Jul 19, 2019
@bantic bantic deleted the bantic/docs/style-selection-options branch July 19, 2019 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants