Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: allow zero for fillColumnIndex #768

Merged
merged 1 commit into from
Sep 17, 2019
Merged

bugfix: allow zero for fillColumnIndex #768

merged 1 commit into from
Sep 17, 2019

Conversation

MichalBryxi
Copy link

@MichalBryxi MichalBryxi commented Sep 13, 2019 •
edited
Loading

fix: #767

@MichalBryxi MichalBryxi force-pushed the bugfix/nth-column-zero branch from 833974c to 619302c Compare September 13, 2019 07:58
mixonic
mixonic approved these changes Sep 13, 2019
View reviewed changes
Copy link
Member

@mixonic mixonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichalBryxi this looks legit, but the build is failing from a linting issue.

@MichalBryxi
Copy link
Author

Ah, sorry. Was just a quick fork & fix for me in the morning. Will lint-fix next week. On my way away from computer now 😄 ⛰ 🚶

@MichalBryxi MichalBryxi force-pushed the bugfix/nth-column-zero branch from 619302c to 1f832cd Compare September 16, 2019 09:20
@MichalBryxi
Copy link
Author

:high-eyebrow-emoji:
I fixed the linter error, but the floating dependencies complain about:

Closing tag `p` (on line 49) without an open tag.
  - errorType: Template Compiler Error
  - location:
    - column: 27
    - file: dummy/pods/docs/guides/body/occlusion/template.hbs
    - line: 36
    - treeDir: /home/travis/build/Addepar/ember-table/tmp/broccoli_persistent_filtertemplate_compiler-input_base_path-HkN3ym8g.tmp
  - message: Build Canceled: Broccoli Builder ran into an error with `broccoli-persistent-filter:TemplateCompiler` plugin. 💥

Not sure whether that is my fault at all?

@mixonic
Copy link
Member

mixonic commented Sep 17, 2019

@MichalBryxi thanks for the follow through. I kicked the build and if it fails again I'll try to get a fix into another PR quickly. It seems like we should maybe pin a dependency more precisely (or there has been a regression etc upstream).

@mixonic mixonic mentioned this pull request Sep 17, 2019
Merged
@mixonic mixonic merged commit 94b1e51 into Addepar:master Sep 17, 2019
@mixonic
Copy link
Member

mixonic commented Sep 17, 2019

Done, thanks @MichalBryxi 🎉

@mixonic
Copy link
Member

mixonic commented Sep 17, 2019 •
edited
Loading

In 2.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mixonic mixonic mixonic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nth-column mode does not work for first column
2 participants
@MichalBryxi @mixonic