Fix vertical scroll indicator placement #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmacleod
force-pushed
the
alex.macleod.temp/fix-vertical-scroll-indicator-placement
branch
from
d071cb4 to
5d0904a
Compare
ahmacleod
changed the title
mixonic
reviewed
Jan 29, 2021
| return generateRows(1); | ||
| return generateRows(100, 1, (row, key) => { | ||
| return String.fromCharCode(key.charCodeAt(0) + 7); | ||
| }); |
There was a problem hiding this comment.
By making this change here, have we lost test coverage for cases where the footer rows are not scrollable?
There was a problem hiding this comment.
This change only affects the example in the docs. We could include an example for each case (single footer row vs. many scrollable), but this effectively demonstrates everything the bottom indicator does.
It's fair to ask the same question of the tests, however. I'll make sure both are covered explicitly.
ahmacleod
deleted the
alex.macleod.temp/fix-vertical-scroll-indicator-placement
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses bottom scroll indicator placement when footer is large enough to scroll. Scroll indicator drops down to bottom of table when body is fully scrolled and obscured footer rows begin to scroll into view. Docs updated to show this example.
Note the border rendering issues with the sticky footer cells. I double-checked, and this is existing behavior. Looks to be related to #771.