-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented repeat attempts by default #394
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
aaccfb4
Implemented repeat attempts by default
danieldisu 7a39044
Expose method in FlakyTestRule
danieldisu e3ac3d3
trigger GitHub actions
danieldisu c60f9f3
Removed bad test and extracted build statement to method
danieldisu 8e7463e
trigger GitHub actions
danieldisu 917c205
Implemented PR suggestions
danieldisu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,6 +44,20 @@ public void repeatStatementReturnedWhenRepeatAnnotationFound() throws Exception | |
assertTrue(resultStatement instanceof RepeatStatement); | ||
} | ||
|
||
@Test | ||
public void repeatStatementReturnedWhenRepeatSetRepeatAttemptsByDefault() throws Exception { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, I don't get the Maybe There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep, it make sense 👍 , changed |
||
Statement baseStatement = new SomeStatement(); | ||
Description description = Description.EMPTY; | ||
|
||
Statement resultStatement = new FlakyStatementBuilder() | ||
.setBase(baseStatement) | ||
.setDescription(description) | ||
.setRepeatAttemptsByDefault(3) | ||
.build(); | ||
|
||
assertTrue(resultStatement instanceof RepeatStatement); | ||
} | ||
|
||
@Test | ||
public void allowFlakyStatementReturnedWhenAllowFlakyAnnotationFound() throws Exception { | ||
Statement baseStatement = new SomeStatement(); | ||
|
@@ -68,6 +82,36 @@ public void allowFlakyStatementReturnedWhenNoAnnotationsFoundButUsesDefault() th | |
assertTrue(resultStatement instanceof AllowFlakyStatement); | ||
} | ||
|
||
@Test | ||
public void lastStatementReturnedWhenRepeatSetRepeatAttemptsByDefaultAndAllowFlakyStatementAtTheSameTime() throws Exception { | ||
Statement baseStatement = new SomeStatement(); | ||
Description description = Description.EMPTY; | ||
|
||
Statement resultStatement = new FlakyStatementBuilder() | ||
.setBase(baseStatement) | ||
.setDescription(description) | ||
.allowFlakyAttemptsByDefault(5) | ||
.setRepeatAttemptsByDefault(3) | ||
.build(); | ||
|
||
assertTrue(resultStatement instanceof RepeatStatement); | ||
} | ||
|
||
@Test | ||
public void allowFlakyStatementReturnedWhenAllowFlakyAnnotationFoundEvenRepeatStatement() throws Exception { | ||
Statement baseStatement = new SomeStatement(); | ||
Description description = Description.EMPTY; | ||
|
||
Statement resultStatement = new FlakyStatementBuilder() | ||
.setBase(baseStatement) | ||
.setDescription(description) | ||
.allowFlakyAttemptsByDefault(5) | ||
.setRepeatAttemptsByDefault(3) | ||
.build(); | ||
|
||
assertTrue(resultStatement instanceof RepeatStatement); | ||
} | ||
|
||
//region Shortcut methods | ||
private Statement createStatement(Statement baseStatement, Description description) { | ||
return new FlakyStatementBuilder() | ||
|
@@ -115,4 +159,4 @@ public void evaluate() throws Throwable { | |
} | ||
} | ||
//endregion | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Repeat] or [Repeat]
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was
[Repeat] or [AllowFlaky]
, fixed!