Reproduce issue #49 and fix it #50
Conversation
…sting same behavior multiple times
…RecyclerView tests
| RecyclerViewActions.actionOnItemAtPosition(position, clickChildWithId(itemToClickId))); | ||
| } | ||
|
|
||
| public static void clickRecyclerViewItemChild(@IdRes int recyclerViewId, int position, String text) { | ||
| onView(withId(recyclerViewId)).perform( | ||
| onView(allOf(withId(recyclerViewId), isDisplayed())).perform( |
There was a problem hiding this comment.
Idea: We could have some static method that constructs this kind of matcher, to avoid duplication of code.
That way we only have the Barista magic in one place. (Maybe two places, because assertions need a different matcher I think).
But this PR can go to production as it is and make people happy already!
There was a problem hiding this comment.
Thanks @Sloy ! Just done it on #51 , that applies the same rule over all Barista Actions. By the way, right now, I don't think that this could be a good idea on Assertions, cos we're trying to be aggressive on the assertion part of the test. We can be happy on the when, but not on the end, if we want to make reliable tests.
But I can be wrong. Let's try that approach and fix it if it doesn't work! 🎉
There was a problem hiding this comment.
Sorry, I've not understood at all your explanation :(
There was a problem hiding this comment.
@despinola Let me try to improve my English... hehehe
@Sloy talked about creating a method that returns the allOf(...) Matcher, and also talked about applying it to Assertions.
Right now, we're only applying it to Actions, to fix the issue you described at #48 .
And then, focusing on applying the new Matcher on the Assertions, I think that it's not needed by now and, in the future, it could be an issue. So I suggest avoiding applying the new suggested method to Assertions, cos it could produce worse tests.
There was a problem hiding this comment.
no no it's not your english.. I just needed more context :p
now it's much better, thanks!
There was a problem hiding this comment.
Thanks for asking, @despinola ! :·)
| import static com.schibsted.spain.barista.BaristaRecyclerViewActions.clickRecyclerViewItemChild; | ||
| import static com.schibsted.spain.barista.BaristaRecyclerViewActions.scrollTo; | ||
|
|
||
| @RunWith(AndroidJUnit4.class) public class RecyclerViewInsideViewPagerTest { |
There was a problem hiding this comment.
Do we have a guideline for formatting of class annotations? I think this is the only place where the class name and the runner are in the same line.
There was a problem hiding this comment.
I just installed AndroidSquare codestyle in my machine and it seems that it formats like this. But let me move to the previous version... Actually, it was hard to me to find the public class statement some minutes ago :·/
|
@Sloy done! Want to check it again? |
|
Thanks for asking @despinola ! I added explaining this magic at #7 , but, as #51 does the same thing than this PR but on all Barista's Actions, I propose to add it later :·) |
|
💪 |
This PR just reproduces this issue #49 and fixes it.
Thanks again for reporting it, @despinola !