Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid talking about swipes #53

Merged
merged 19 commits into from
May 10, 2017
Merged

Avoid talking about swipes #53

merged 19 commits into from
May 10, 2017

Conversation

rocboronat
Copy link
Member

Implementation of #13 , cos all Barista's Action classes are related with Android widgets, in exception of SwipeActions. Let's use the same naming everywhere.

# Conflicts:
#	library/src/main/java/com/schibsted/spain/barista/BaristaSwipeActions.java
@Sloy
Copy link
Member

Sloy commented May 10, 2017

Is it me? Or you're dragging your open branches into new ones?
This PR includes a lot of changes unrelated to the PR title.

@rocboronat rocboronat requested a review from Sloy May 10, 2017 15:09
@rocboronat
Copy link
Member Author

Yes, I missed that as we squash and merge, GitHub doesn't clean the other branch commits when the branch is merged. Sorry... please, just look at the last four commits... or even the files changed tab :·)

@rocboronat rocboronat merged commit 6d98b80 into master May 10, 2017
@rocboronat rocboronat deleted the avoid-talking-about-swipes branch May 10, 2017 15:36
@rocboronat rocboronat mentioned this pull request May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants