Autoscroll on RadioButtonsAction #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sloy
reviewed
May 10, 2017
| @@ -13,17 +14,20 @@ | |||
| public class BaristaRadioButtonActions { | |||
|
|
|||
| public static void clickRadioButtonItem(@IdRes int radioGroupId, @IdRes int itemToClickId) { | |||
| scrollTo(radioGroupId); | |||
There was a problem hiding this comment.
In normal clicks we just do .perform(scrollTo(), click()).
Are they different? Which one is better?
There was a problem hiding this comment.
Actually, Barista.scrollTo() does the trick of doing the scroll 100 times to fix an unknown Espresso bug. And I guess that just perming an Espresso's scrollTo() doesn't work on some scenarios. But great question.
alorma
approved these changes
May 11, 2017
|
Thanks for your feedback, @alorma ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we explained at #52 , Barista is intended to scroll everytime is needed. But looking at tests and code, we noticed that it wasn't happening when clicking a RadioButton item.
This PR adds tests to check it and implements the solution of those tests.
Fixes #54