Create methods to avoid knowing the ID of the ViewPager if there's only one ViewPager #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sloy
approved these changes
May 11, 2017
|
|
||
| @NonNull | ||
| public static Matcher<View> displayedAssignableFrom(final Class<? extends View> clazz) { | ||
| return allOf(isDisplayed(), isAssignableFrom(clazz)); |
There was a problem hiding this comment.
Suggestion: A nice trick to avoid the ugly clazz hack is telling what it's for. Like viewClass.
There was a problem hiding this comment.
Nice! Actually, I copied it from the original isAssignableFrom method... but your idea is better :·)
| @@ -31,6 +31,8 @@ dependencies { | |||
| } | |||
| compile 'com.android.support.test.uiautomator:uiautomator-v18:2.1.2' | |||
| compile 'com.android.support:support-annotations:25.1.0' | |||
| compile 'com.android.support:support-core-ui:25.1.0' | |||
There was a problem hiding this comment.
Q: Why is this new dependency for?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original idea? Look here! #8