Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that click() scrolls when needed #64

Merged
merged 10 commits into from
May 17, 2017
Merged

Conversation

rocboronat
Copy link
Member

As #62 explains, the autoscroll magic stopped working. We think that it happened at #51.

This PR reproduces the issue and fixes it.

But... it creates a new issue: it breaks the feature added at #51. So, we also test it and fix it.

@rocboronat rocboronat added the wip label May 16, 2017
@rocboronat rocboronat requested a review from Sloy May 16, 2017 14:30
@rocboronat rocboronat added the bug label May 16, 2017
@rocboronat rocboronat removed the wip label May 16, 2017
@@ -25,7 +25,7 @@ protected void onCreate(Bundle savedInstanceState) {
@Override
public void onCheckedChanged(RadioGroup group, @IdRes int checkedId) {
TextView textView = (TextView) findViewById(R.id.selected_item);
textView.setText("" + checkedId);
textView.setText(String.valueOf(checkedId));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just fixes an AS warning

Copy link
Member

@Sloy Sloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of changes here. Reviewing commit by commit was helpful to understand what was going on.

Great job reproducing and fixing issues!
👍

@rocboronat
Copy link
Member Author

Thank you @Sloy . I really appreciate that lovely words.

🏩

@rocboronat rocboronat merged commit f9f6c9b into master May 17, 2017
@rocboronat rocboronat deleted the click-and-scroll-if-needed branch May 17, 2017 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants