-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check that click() scrolls when needed #64
Conversation
…them on instrumentation tests
…ction levels at click() methods
@@ -25,7 +25,7 @@ protected void onCreate(Bundle savedInstanceState) { | |||
@Override | |||
public void onCheckedChanged(RadioGroup group, @IdRes int checkedId) { | |||
TextView textView = (TextView) findViewById(R.id.selected_item); | |||
textView.setText("" + checkedId); | |||
textView.setText(String.valueOf(checkedId)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just fixes an AS warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of changes here. Reviewing commit by commit was helpful to understand what was going on.
Great job reproducing and fixing issues!
👍
Thank you @Sloy . I really appreciate that lovely words. 🏩 |
As #62 explains, the autoscroll magic stopped working. We think that it happened at #51.
This PR reproduces the issue and fixes it.
But... it creates a new issue: it breaks the feature added at #51. So, we also test it and fix it.