Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www.goplay.be #144701

Closed
adguard-bot opened this issue Mar 5, 2023 · 24 comments
Closed

www.goplay.be #144701

adguard-bot opened this issue Mar 5, 2023 · 24 comments
Assignees
Labels
A: Cannot reproduce Filters devs cannot reproduce this issue A: In progress Work on the issue is in progress A: Waiting for data Waiting for more information from the user N: AdGuard Browser Extension P3: Medium T: Incorrect Blocking

Comments

@adguard-bot
Copy link

Issue URL (Incorrect Blocking)

https://www.goplay.be/video/recht-naar-de-gevangenis/recht-naar-de-gevangenis-s1/recht-naar-de-gevangenis-s1-aflevering-1#autoplay

Comment

video doesn't play error

Screenshots

Screenshot 1

Screenshot 1

Screenshot 2

Screenshot 2

System configuration

Information value
AdGuard product: AdGuard Browser extension v4.1.53
Browser: Opera
Stealth mode: disabled
Filters: Ad Blocking:
AdGuard Base

Privacy:
AdGuard Tracking Protection

Annoyances:
AdGuard Annoyances

Language-specific:
AdGuard Dutch
@contribucious
Copy link
Contributor

Related:

uBlockOrigin/uAssets#16881 (uBO)

@jellizaveta jellizaveta added the A: In progress Work on the issue is in progress label Mar 6, 2023
@jellizaveta
Copy link
Contributor

I get the same error only when the VPN is enabled in Opera. @AdguardTeam/filters-maintainers could you please take a look?

@jellizaveta jellizaveta added A: Cannot reproduce Filters devs cannot reproduce this issue A: Waiting for data Waiting for more information from the user labels Mar 6, 2023
@contribucious
Copy link
Contributor

contribucious commented Mar 6, 2023

(Just for info)

I am not the reporter but after testing (with same filters and AG product used, but under Firefox 110.0.1), I find that the rule below found here is enough on its own to fix this issue:

@@||imasdk.googleapis.com/js/sdkloader/ima3_dai.js$script,domain=goplay.be
💡 redirect=noopjs doesn't work here, but an adequate redirect is planned.

Note:

  • ima3.js is currently handled by ||imasdk.googleapis.com/js/sdkloader/ima3.js$script,redirect=noopjs,domain=goplay.be from AdGuard Dutch and
  • DoubleClick stuff is handled there too.

@jellizaveta
Copy link
Contributor

Thanks for checking, I will add this rule.

@contribucious
Copy link
Contributor

Glad to help. 🙂

@adguard-bot
Copy link
Author

Issue URL (Incorrect Blocking)

https://www.goplay.be/video/tulpen-uit-antwerpen/tulpen-uit-antwerpen/tulpen-uit-antwerpen-s1-aflevering-5#autoplay

Comment

Username: @Yiha777

something went wrong while setting up a google dai stream

Screenshots

Screenshot 1

Screenshot 1

Screenshot 2

Screenshot 2

System configuration

Information value
AdGuard product: AdGuard Browser extension v4.1.53
Browser: Yandex
Stealth mode: disabled
Filters: Ad Blocking:
AdGuard Base

Privacy:
AdGuard Tracking Protection,
Peter Lowe's Blocklist

Language-specific:AdGuard Turkish,
AdGuard French,
AdGuard Russian,
AdGuard Chinese,
AdGuard German,
AdGuard Japanese,
AdGuard Dutch,
AdGuard Spanish/Portuguese,
Bulgarian list,
EasyList Czech and Slovak,
EasyList Italy,
EasyList Lithuania,
Latvian List,
Liste AR,
AdBlockID,
EasyList Thailand,
Hungarian,
ABPVN List,
Official Polish filters for AdBlock, uBlock Origin & AdGuard,
List-KR,
Adblock List for Finland,
Polish Anti Adblock Filters,
Frellwit's Swedish Filter,
Dandelion Sprout's Nordic Filters

@adguard-bot adguard-bot reopened this Mar 12, 2023
@github-actions github-actions bot removed A: Cannot reproduce Filters devs cannot reproduce this issue A: In progress Work on the issue is in progress A: Waiting for data Waiting for more information from the user labels Mar 12, 2023
@contribucious
Copy link
Contributor

contribucious commented Mar 13, 2023

Regarding the above error from @Yiha777

 
I don't know if they currently do an A/B testing regarding the delivery method & co, but I can't reproduce that in my usual Firefox profile while … I always can in a fresh one (reproducible even with just Base, Tracking Protection and Dutch filters enabled).

💡 In this case, the second rule from here is indeed also required to allow the video to play:
@@||doubleclick.net^$xmlhttprequest,domain=goplay.be
… but then, you have video ads — and the xml-prune solution given in the above link doesn't work for me (even in the AG format).

➡️ Need more analysis, so I'll let the team dig deeper for this case. 👀 #DAI

@Alex-302 Alex-302 added the A: In progress Work on the issue is in progress label Mar 13, 2023
@Alex-302
Copy link
Member

@Yiha777

something went wrong while setting up a google dai stream

Hi. I can't reproduce this issue.
Could you please chech with AdGuard's filters only?

@Alex-302 Alex-302 added A: Cannot reproduce Filters devs cannot reproduce this issue A: Waiting for data Waiting for more information from the user labels Mar 13, 2023
@Yiha777
Copy link

Yiha777 commented Mar 13, 2023

@Yiha777

something went wrong while setting up a google dai stream

Hi. I can't reproduce this issue. Could you please chech with AdGuard's filters only?

Hi, it could work but I see that my browser has problems playing it. I don't have the message about google dai stream anymore.

@contribucious
Copy link
Contributor

Hi @Yiha777, 👋

I don't have the message about google dai stream anymore.

Just to clarify:

  • … after adding my above rule (cf. your thumb up) or after keeping only AdGuard's filters enabled?
  • Also, do you see video ads? And/or small white lines (a few centimeters long) at multiple places in the progress bar of the player?
ℹ️ You have, in any case, indeed way too many language-specific filters activated. This future behavior will come in handy soon, I think. If … you haven't taken this at face value and enabled them all manually. 😉

@contribucious
Copy link
Contributor

contribucious commented Mar 13, 2023

Hi @Alex-302,

After slightly more thorough tests, I clearly found a pattern (tested 4 if not 5 times for reproducibility, in private window of a brand new fresh and clean profile of Firefox 110.0.1 with unlogging, closing the latter and starting again each time).

Could you try to reproduce this on your side?

(STR, to recreate the problem of @Yiha777 > Accepting the cookies)
Reveal …
Ideally, in a private browsing window.
  1. Enable only Base, Tracking Protection and Dutch filters.
  2. Go to this link. Or better, @Yiha777's one.
↪️ EDIT: I just saw now in the writing of this post that all my tests were based on the wrong link (the one in the first post), different from the one from @Yiha777. BUT, anyway, I was able to replicate that with his/her link as well.
  1. Either click on the green button Verder naar GoPlay (Continue to GoPlay) or Meer informatie → then the green button Alles akkoord (Agree all).
  2. Observe the error in question appearing: Something went wrong while setting up a Google DAI stream. ✖️

And this one now?

(STR, to avoid this problem > Refusing the cookies)
Reveal …
Ideally, in a private browsing window too, after unlogging and closing it before.
  1. Same as previous STR (choice of filters).
  2. Same as previous STR (link to click).
  3. Click on Meer informatie → then the gray button Niets akkoord (Disagree).
  4. Observe that all is OK, the video starts playing (ad-free and without error). ✔️
💡 Luckily, I note as an additional test that when the AdGuard Annoyances filter is used, cookies are auto-refused thanks to that rule and therefore the error does not appear in this case (a lot of people are therefore spared ☺️).

@Yiha777
Copy link

Yiha777 commented Mar 13, 2023

Hi @Yiha777, 👋

I don't have the message about google dai stream anymore.

Just to clarify:

  • … after adding my above rule (cf. your thumb up) or after keeping only AdGuard's filters enabled?
  • Also, do you see video ads? And/or small white lines (a few centimeters long) at multiple places in the progress bar of the player?
ℹ️ You have, in any case, indeed way too many language-specific filters activated. This future behavior will come in handy soon, I think. If … you haven't taken this at face value and enabled them all manually. 😉

Hi, after keeping only AdGuard's filters enabled.
But my browser (Yandex) won't play anything on this site so it's hard to say if it will really work.

@contribucious
Copy link
Contributor

OK, thank you for the clarification. 👍

@Alex-302
Copy link
Member

@contribucious #144701 (comment)

Works on my end.

@Yiha777 Is Yandex Browser's intednal ad blocker disabled?

@Yiha777
Copy link

Yiha777 commented Mar 14, 2023

Adguard is Yandex's internal ad blocker.

@Alex-302
Copy link
Member

Alex-302 commented Mar 14, 2023

@Yiha777 In browser://tune/ there are also 2 in Network safety section

Details

image

At least in Russian version.

Adguard is Yandex's internal ad blocker.

No, it is just a button to install from Chrome Store)

@Yiha777
Copy link

Yiha777 commented Mar 14, 2023

@Alex-302 Ok, it plays now with Antishock and Adguard disabled. With Adguard, only Adguard base filter, it just keeps loading.
I have only Antishock (the beetle) and Adguard in English version.

@krystian3w
Copy link
Contributor

krystian3w commented Mar 14, 2023

Or Opera addon store due Yandex CSS theme still works on Opera addons store.

@Yiha777
Copy link

Yiha777 commented Mar 14, 2023

@Alex-302 I deleted all my cookies and rejected all while logging in. I white-listed the site on the two ad blockers and now it all works without ads. So thanks for all the tips guys :)

@contribucious
Copy link
Contributor

contribucious commented Mar 14, 2023

@Alex-302

@contribucious #144701 (comment)

Works on my end.

OK, thank you for your test. More analysis needed then. 😉

For more info/context about my tests in Firefox:

  • "Tracking content" option was always unchecked regarding the ETP — one of my tests was even with the ETP specifically disabled for this website (with the same result).
  • An unfiltered DNS was always used via the use of Cloudflare DoH in the Firefox settings.
  • AG for Windows protection was in pause mode during all my tests with the AG Browser extension.
  • No other blocking causes that I can think of, like an ad blocker of a security product, etc.

@Yiha777

Note that sometimes there may be no video ads anyway though.

↪️ So, IMHO, you better to remove goplay.be from your Allowlist in AdGuard and activating at least Dutch in addition to Base for any present and future countermeasures.

💡 Activating Base filter only (even for a test, trying to be as minimalist as possible) will often block too many stuff (due to many generic/broad rules in this filter, which are typically unblocked only for a given website in the appropriate language filter — the Dutch one in this case). ☺️

@Yiha777
Copy link

Yiha777 commented Mar 14, 2023

It's removed from Allowlist. Annoyance blocker does the rest.

@contribucious
Copy link
Contributor

Also, you may want to disable this particular option until this behavior is implemented and enable only a few language-specific filters you really want/plan to use. 😉

@Nomes77
Copy link
Contributor

Nomes77 commented Mar 29, 2023

At @Alex-302 is there any update on this comment, #144701 (comment)? Because it still doesn't work.

@krystian3w
Copy link
Contributor

krystian3w commented Mar 29, 2023

Maybe need convert rule to user script (to cover uBo fans by TamerMonkey/ViolentMonkey) or uBo custom scriptlet (without second WebExtension).

It's unlikely that anyone will spend several days figuring out how to use, for example, set-constant to fool the site into thinking that we don't give consents.

AdGuard may in the future rewrite this into its delayed-click scriptlet, so it won't need to be added to AdGuard Extra (As one day rules with pure JavaScript will be deprecated). The uBo in that case will have to wait to see if the simulate-event-poc (uBlockOrigin/uBlock-issues#2229) will be in the uBo available to all and if not if they will make an exception to close on one BeNeLux site with rejection of GDPR/CCPA consents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Cannot reproduce Filters devs cannot reproduce this issue A: In progress Work on the issue is in progress A: Waiting for data Waiting for more information from the user N: AdGuard Browser Extension P3: Medium T: Incorrect Blocking
Projects
None yet
Development

No branches or pull requests

7 participants