Incorrect filter locale displayed after language change

[TheHasagi]

Incorrect filter translation after language is changed (See the screenshot)

Preconditions are:

Switch device language for RU (example), AdGuard language is RU.

Steps to reproduce

1. Switch language of AdGuard to EN
2. Open AdGuard - Settings - DNS filtering - DNS requests blocking

Expected behavior

SDN filter should look with the selected locale (EN)

Actual behavior

SDN filter shown in RU translation

Screenshot:

[ameshkov]

Hmm, @admitrevskiy where does this translation come from? I thought there are no translations of the DNS filter lists?

[admitrevskiy]

We store SDN filter name in strings.xml. Looks like on the first SDN filter initialization selected locale was ru. Anyway, I think we should hide this phrase and make it not translatable.

[ameshkov]

Well, in the case of custom DNS filter lists, the user enters their names manually so there's no need to bother.

This one is preinstalled so ideally, it should be "translatable". It's just we'd better do it in runtime.

[lancelot-moon]

Yes, AdGuard SDN filter in DNS filter should be translated.
#2964
Thanks.

[lancelot-moon]

This isn't fixed in v3.2.140.

My Android system language is Chinese.

After cleanly installing v3.2.140, if changing AdGuard's language from system (Chinese) to English or any other language, AG SDN filter still shows Chinese.

Afterwards, I tried to change Android system language from Chinese to English.
But AG SDN filter still show Chinese even if changing AdGuard's language to any other languages.

[TheHasagi]

@lancelot-moon

As you can see the milestone is set to 3.3 and it cannot be fixed in 3.2.140. Please, stand by.

[lancelot-moon]

@TheHasagi
I knew what you said.
Then you should not mark that you had fixed this in the changelog.
https://adguard.com/en/versions/android/release.html
[Fixed] "DNS filters" screen uses incorrect locale after language change #2971

[TheHasagi]

Fair enough :)

[admitrevskiy]

Done.