Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ':if()' and ':if-not()' pseudo-classes #151

Closed
zloyden opened this issue Nov 22, 2022 · 3 comments
Closed

Remove ':if()' and ':if-not()' pseudo-classes #151

zloyden opened this issue Nov 22, 2022 · 3 comments
Assignees
@slavaleleka
Labels
Resolution: Fixed Status: Closed Version: ExtendedCss v2.0 Patch

Comments

@zloyden
Copy link

zloyden commented Nov 22, 2022

I suppose, and according to the discussion uBlockOrigin/uBlock-issues#2376, it is time to remove this pseudo-class https://github.com/AdguardTeam/ExtendedCss/#extended-css-if-not.
@krystian3w
Copy link

krystian3w commented Nov 29, 2022 •
edited
Loading

P.S. Removed form support in uBo also is :if(...): ##.TimelineItem:if(#issue-1459586391). I don't detected use in AG filters added to uBo Dashboard.

CSSTree also need update parser to longer use [-ext-has='...'] - or convert by script into uBo file (if recover support will by still rejected).

@slavaleleka
Copy link
Contributor

@krystian3w
you mean that :if() pseudo-class is no longer supported by uBo?

@krystian3w
Copy link

krystian3w commented Nov 29, 2022 •
edited
Loading

Yes, rules no match elements, same for [-ext-has] syntax.

Two may need rewrite no logner allowed charcters in :contains() aka AdguardTeam/FiltersCompiler#156:

image

image

I think :if( ) don't back due no exist in approved AdGuard Filters* in uBo Dashboard. Also removed from wiki: https://github.com/gorhill/uBlock/wiki/Procedural-cosmetic-filters/_compare/83d971fd5915a1d9490e69574b60664c79486a00...2c704d06b896e92511cf8014d89582c8c1dbc3c4

* - rejected is:

  • Germany version by okiehsch - added few missed domains and maybe still watch changes,

  • Dutch version after select "EasyDutch" by Netherland Brothers (in uBo Dashboard).

    removed is: Russian version after ameshkov recommendation to use "RU AD List"

[-ext-has] It probably backfired into rewrite parser (I counted ≈1000 uses in approved lists, Maybe this will make a reply from Gorhill in a few days).

@krystian3w krystian3w mentioned this issue Nov 29, 2022
Open
@adguard-bot adguard-bot changed the title Remove pseudo-class :if-not() Remove :if() and :if-not() pseudo-classes Dec 1, 2022
adguard pushed a commit that referenced this issue Dec 1, 2022
@slavaleleka
ditch :if() and :if-not() pseudo-classes. #151 AG-17744
5bd9ca4 
Squashed commit of the following:

commit ff17117414a5e50cb2a6fe2d4cd5672a9d50a0da
Merge: 9f278b7 77a0083
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Thu Dec 1 18:59:31 2022 +0200

    Merge branch 'master' into feature/AG-17744

commit 9f278b7fefab0c88e8b3f82c226a4983ac83989c
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Thu Dec 1 17:33:32 2022 +0200

    ditch 'if' and 'if-not' pseudo-classes
@adguard-bot adguard-bot changed the title Remove :if() and :if-not() pseudo-classes Remove ':if()' and ':if-not()' pseudo-classes Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavaleleka slavaleleka

Labels
Resolution: Fixed Status: Closed Version: ExtendedCss v2.0 Patch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@adguard-bot @zloyden @krystian3w @slavaleleka