use isBrowserSupported in tests

AdguardTeam · Jan 12, 2023 · b7b1156 · b7b1156
1 parent 53884e6
commit b7b1156
Show file tree

Hide file tree

Showing 6 changed files with 37 additions and 25 deletions.
diff --git a/src/helpers/check-compatibility.js b/src/helpers/check-compatibility.js
@@ -2,6 +2,9 @@
  * Checks if current browser is supported
  * To be injected to every scriptlet at build time
  *
+ * isBrowserSupported is included to simplify injection
+ * by skipping dependencies attachment
+ *
  * @throws error on unsupported browser
  */
 export function checkCompatibility() {
@@ -23,3 +26,23 @@ export function checkCompatibility() {
         throw new Error('Browser is not supported by AdGuard Scriptlets.');
     }
 }
+
+/**
+ * Checks if current browser is supported
+ * For usage in tests
+ *
+ * @returns {boolean} true if current browser is supported
+ */
+export const isBrowserSupported = () => {
+    // arr.every() is not used because missing global method
+    // would throw ReferenceError when added to array
+    return typeof fetch !== 'undefined'
+        && typeof Proxy !== 'undefined'
+        && typeof Reflect !== 'undefined'
+        && typeof Response !== 'undefined'
+        && typeof Array.prototype.includes !== 'undefined'
+        && typeof String.prototype.includes !== 'undefined'
+        && typeof String.prototype.startsWith !== 'undefined'
+        && typeof String.prototype.endsWith !== 'undefined'
+        && typeof Element.prototype.attachShadow !== 'undefined';
+};
diff --git a/tests/scriptlets/hide-in-shadow-dom.test.js b/tests/scriptlets/hide-in-shadow-dom.test.js
@@ -1,5 +1,6 @@
 /* eslint-disable no-underscore-dangle */
 import { runScriptlet, clearGlobalProps } from '../helpers';
+import { isBrowserSupported } from '../../src/helpers';
 
 const { test, module } = QUnit;
 const name = 'hide-in-shadow-dom';
@@ -22,12 +23,7 @@ const afterEach = () => {
 
 module(name, { beforeEach, afterEach });
 
-// some browsers do not support ShadowRoot
-// for example, Firefox 52 which is used for browserstack tests
-// https://developer.mozilla.org/en-US/docs/Web/API/ShadowRoot
-const isSupported = typeof Element.prototype.attachShadow !== 'undefined';
-
-if (!isSupported) {
+if (!isBrowserSupported()) {
     test('unsupported', (assert) => {
         assert.ok(true, 'Browser does not support it');
     });

diff --git a/tests/scriptlets/prevent-fetch.test.js b/tests/scriptlets/prevent-fetch.test.js
@@ -1,7 +1,10 @@
 /* eslint-disable no-underscore-dangle, no-console */
 import { runScriptlet, clearGlobalProps } from '../helpers';
-import { startsWith } from '../../src/helpers/string-utils';
-import { isEmptyObject } from '../../src/helpers/object-utils';
+import {
+    isEmptyObject,
+    startsWith,
+    isBrowserSupported,
+} from '../../src/helpers';
 
 const { test, module } = QUnit;
 const name = 'prevent-fetch';
@@ -26,10 +29,8 @@ const afterEach = () => {
 
 module(name, { beforeEach, afterEach });
 
-const isSupported = typeof fetch !== 'undefined' && typeof Proxy !== 'undefined' && typeof Response !== 'undefined';
-
 // TODO: add testcases with POST requests
-if (!isSupported) {
+if (!isBrowserSupported()) {
     test('unsupported', (assert) => {
         assert.ok(true, 'Browser does not support it');
     });

diff --git a/tests/scriptlets/remove-in-shadow-dom.test.js b/tests/scriptlets/remove-in-shadow-dom.test.js
@@ -1,5 +1,6 @@
 /* eslint-disable no-underscore-dangle */
 import { runScriptlet, clearGlobalProps } from '../helpers';
+import { isBrowserSupported } from '../../src/helpers';
 
 const { test, module } = QUnit;
 const name = 'remove-in-shadow-dom';
@@ -22,12 +23,7 @@ const afterEach = () => {
 
 module(name, { beforeEach, afterEach });
 
-// some browsers do not support ShadowRoot
-// for example, Firefox 52 which is used for browserstack tests
-// https://developer.mozilla.org/en-US/docs/Web/API/ShadowRoot
-const isSupported = typeof Element.prototype.attachShadow !== 'undefined';
-
-if (!isSupported) {
+if (!isBrowserSupported()) {
     test('unsupported', (assert) => {
         assert.ok(true, 'Browser does not support it');
     });

diff --git a/tests/scriptlets/trusted-replace-fetch-response.test.js b/tests/scriptlets/trusted-replace-fetch-response.test.js
@@ -1,6 +1,6 @@
 /* eslint-disable no-underscore-dangle, no-console */
 import { runScriptlet, clearGlobalProps } from '../helpers';
-import { startsWith } from '../../src/helpers/string-utils';
+import { startsWith, isBrowserSupported } from '../../src/helpers';
 
 const { test, module } = QUnit;
 const name = 'trusted-replace-fetch-response';
@@ -25,9 +25,7 @@ const afterEach = () => {
 
 module(name, { beforeEach, afterEach });
 
-const isSupported = typeof fetch !== 'undefined' && typeof Proxy !== 'undefined' && typeof Response !== 'undefined';
-
-if (!isSupported) {
+if (!isBrowserSupported()) {
     test('unsupported', (assert) => {
         assert.ok(true, 'Browser does not support it');
     });

diff --git a/tests/scriptlets/xml-prune.test.js b/tests/scriptlets/xml-prune.test.js
@@ -1,6 +1,6 @@
 /* eslint-disable no-underscore-dangle, no-console */
 import { runScriptlet, clearGlobalProps } from '../helpers';
-import { startsWith } from '../../src/helpers/string-utils';
+import { startsWith, isBrowserSupported } from '../../src/helpers';
 
 const { test, module } = QUnit;
 const name = 'xml-prune';
@@ -26,9 +26,7 @@ const afterEach = () => {
 
 module(name, { beforeEach, afterEach });
 
-const isSupported = typeof fetch !== 'undefined' && typeof Proxy !== 'undefined' && typeof Response !== 'undefined';
-
-if (!isSupported) {
+if (!isBrowserSupported()) {
     test('unsupported', (assert) => {
         assert.ok(true, 'Browser does not support it');
     });