Fix event firing on native click (prebid#3589)

Adikteev · Mar 1, 2019 · dd26503 · dd26503
1 parent 5112950
commit dd26503
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/src/native.js b/src/native.js
@@ -144,6 +144,7 @@ export function fireNativeTrackers(message, adObject) {
   }
 
   (trackers || []).forEach(triggerPixel);
+  return message.action;
 }
 
 /**

diff --git a/src/secureCreatives.js b/src/secureCreatives.js
@@ -52,7 +52,9 @@ function receiveMessage(ev) {
         return;
       }
 
-      fireNativeTrackers(data, adObject);
+      const trackerType = fireNativeTrackers(data, adObject);
+      if (trackerType === 'click') { return; }
+
       auctionManager.addWinningBid(adObject);
       events.emit(BID_WON, adObject);
     }

diff --git a/test/spec/native_spec.js b/test/spec/native_spec.js
@@ -85,7 +85,8 @@ describe('native.js', function () {
   });
 
   it('fires click trackers', function () {
-    fireNativeTrackers({ action: 'click' }, bid);
+    const trackerType = fireNativeTrackers({ action: 'click' }, bid);
+    expect(trackerType).to.equal('click');
     sinon.assert.calledOnce(triggerPixelStub);
     sinon.assert.calledWith(triggerPixelStub, bid.native.clickTrackers[0]);
   });
-Original file line number
+Diff line change
@@ Expand Up / @@ -144,6 +144,7 @@ export function fireNativeTrackers(message, adObject) { @@
       }
       (trackers || []).forEach(triggerPixel);
+      return message.action;
     }
     /**
@@ Expand Down @@