fix: Enable auto-upgrade in beta clusters with a release channel (#682) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enable auto-upgrade in beta clusters with a release channel Without this setting, a cluster with a default node pool will fail when a release channel is specified. The API responds with: Error: error creating NodePool: googleapi: Error 400: Auto_upgrade cannot be false when release_channel REGULAR is set., badRequest This is noted in the documentation, that use of a release channel requires auto-upgrade and auto-repair to be enabled: https://cloud.google.com/kubernetes-engine/docs/concepts/release-channels#new-cluster * Only include comment in beta block, run make build The previous location I placed the comment meant that it was in place even in non-beta clusters, so the comment was describing behavior that wasn't actually in place. Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this setting, a cluster with a default node pool will fail when
a release channel is specified. The API responds with:
Error: error creating NodePool: googleapi: Error 400: Auto_upgrade cannot be false when release_channel REGULAR is set., badRequest
This is noted in the documentation, that use of a release channel
requires auto-upgrade and auto-repair to be enabled:
https://cloud.google.com/kubernetes-engine/docs/concepts/release-channels#new-cluster
The previous location I placed the comment meant that it was in place
even in non-beta clusters, so the comment was describing behavior that
wasn't actually in place.
Co-authored-by: Bharath KKB bharathkrishnakb@gmail.com