Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request/enhancement] settings file #26

Closed
marc-vdm opened this issue Jan 9, 2020 · 19 comments
Closed

[feature request/enhancement] settings file #26

marc-vdm opened this issue Jan 9, 2020 · 19 comments

Comments

@marc-vdm
Copy link
Contributor

marc-vdm commented Jan 9, 2020

Would it be a good idea to have a settings file?

Certain things could be stored here like;

  • minimum CPU load before going to turbo
  • minimum load factor before going to turbo
  • true/false for allowing turboboost to be switched off when on battery
    And any other items that can be changed.
@Exorust
Copy link

Exorust commented Jan 11, 2020

This is similar to #30.

@AdnanHodzic
Copy link
Owner

Duplicate of #30 but let's continue the discussion here.

As I suggested in #30

I like this idea. My idea (which I had in plan for one of the future releases) was to allow users to specify these themselves using CLI. Something like having another "advanced" mode which would allow you to easily/interactively tweak these to your own liking.

what you're proposing here would make perfect sense. In meantime I just want to think about what would be simpler option for the end user. Adding these interactively through a CLI or a "settings" file.

@marc-vdm
Copy link
Contributor Author

I would personally say that a file gives a good overview to users of what settings there are and how they could be changed, and perhaps implementation is easier, but I'm not sure of that.
However, there are probably more opinions on this so I`d be happy to hear those.

@poVoq
Copy link

poVoq commented Jan 12, 2020

Maybe at least some default presets would be good? For example one that stays low as long as possible and only switches to performance when starting a game for something like that?
Right now it seems quite trigger happy with switching up the CPU speed on regular browser use quite often.

@AdnanHodzic
Copy link
Owner

I would personally say that a file gives a good overview to users of what settings there are and how they could be changed, and perhaps implementation is easier, but I'm not sure of that.
However, there are probably more opinions on this so I`d be happy to hear those.

Let's no go with what's easiest to implement, let's go with what's best to implement :)

Maybe at least some default presets would be good? For example one that stays low as long as possible and only switches to performance when starting a game for something like that?
Right now it seems quite trigger happy with switching up the CPU speed on regular browser use quite often.

Having various presets is also a good idea.

I agree that in current implementation it is trigger happy. I'm thinking of different ways to make it less this way, by possibly combining both input from load and CPU usage (and then in future also CPU temperature + fan speeds).

Either way I'll be thinking what's the best way to proceed with this in upcoming period. In meantime if anyone else is interested in having this feature, I'd be very interested in hearing what you have to say.

@Red-Eyed
Copy link
Contributor

Red-Eyed commented Aug 5, 2020

I could look at it. And maybe implement first draft when have a time
python's stdlib has good config parser

So, config should:

  • contain default values
  • where it should be placed?

@AdnanHodzic
Copy link
Owner

  • where it should be placed?

I was about to say in the same directory as auto-cpufreq, this way whoever changes the default values can see what was changed with git.

But, this won't apply if app was installed using snap, AUR or any other package. Hence, maybe it would be the best to place to ~/.auto-cpufreq?

@Red-Eyed
Copy link
Contributor

Red-Eyed commented Aug 5, 2020

Yeah, I also inclined to thing that this would be a nice place.
But, what about other users? as it seems that auto-cpufreq is for multi user, isn't it?

@AdnanHodzic
Copy link
Owner

True, but for now we should focus that it works well for 1 user with root access :)

@Red-Eyed
Copy link
Contributor

Red-Eyed commented Aug 5, 2020

I just thought, that how could we determine user dir, if auto-cpufreq is run with root?
maybe we should place the config like tlp is doing this in /etc ?

@AdnanHodzic
Copy link
Owner

True, /etc/auto-cpufreq sounds good.

Since auto-cpufreq snap is running in restricted mode, I'm trying to pick least intrusive location, as I'll need to request access to this location for snap. But in worst case scenario I can even place this in different location for snap in case it turns out to be too much hassle.

@crian
Copy link

crian commented Aug 11, 2020

Please follow the xdg base directory specification when placing a config file into the user home dir.

@whorider
Copy link

whorider commented Oct 8, 2020

Another setting to consider, please:
I am visually impaired and I'd like to slow the refresh rate from default 5 to ~10 seconds in --monitor mode; It's a little too fast for my eyes ;)

@thhart
Copy link

thhart commented Jan 7, 2021

Hi, I can see it is not easy to have configuration in caged environments, this is a starting point for snap:

https://snapcraft.io/docs/adding-snap-configuration

@thhart
Copy link

thhart commented Jan 7, 2021

IMHO it is not necessary to have a rich configuration interface. But it would be very helpful to have some options being configurable in general. Personally I would like to be able to configure following threshold:
Turbo mode on/off depending on load average and temp

@tamimmahmudkhan
Copy link

I would like the minimum amount of configurables to be similar to what the cpupower utility allows. A max/min frequency and governor selection with the addition of a battery toggle.

@AdnanHodzic
Copy link
Owner

I'm happy to report that with release of auto-cpufreq v1.7.0 this feature is implemented!

@ashwinmahantha
Copy link

Hi @AdnanHodzic,
I just started using this tool. Thanks for all the work you have done!
A couple of questions:

  1. Has this been addressed? If yes, then, does user need to do anything here?

I agree that in current implementation it is trigger happy. I'm thinking of different ways to make it less this way, by possibly combining both input from load and CPU usage (and then in future also CPU temperature + fan speeds).

  1. Is the list of options for config file mentioned in github page exhaustive? If no, then, where can I find all the options.
    Configuring auto-cpufreq

Again, thanks for the awesome tool!

@AdnanHodzic
Copy link
Owner

  1. Has this been addressed? If yes, then, does user need to do anything here?

Yes it has, long time ago.

  1. Is the list of options for config file mentioned in github page exhaustive? If no, then, where can I find all the options.
    Configuring auto-cpufreq

At the moment that's the whole list of additional things that can be manually configured. As those were the most wanted settings.

If you wish to extend this list, please feel free to make a code contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants