-
-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Xbox controller's battery makes it switch to battery profile #753
Comments
huh thats weird but makes sense. for the time being try overriding the Governor in the auto-cpufreq gui. this will keep the cpu at full performance even when on battery. |
In addition to what @PurpleWazard said, alternatively you can also use --force flag, or config file. |
Seems we need more intelligent battery checking here. |
@shadeyg56 That would be the best solution. And maybe you could also ignore all batteries if desktop is detected + possible override in conf file (in case of ups). |
@AdnanHodzic I made battery portion of config the same as charger as soon as I found out that auto-cpufreq is impacting performance. But it would be nice to have a way to filter out batteries. I haven't yet tested it with xone driver on laptop, but I suspect it would go into battery mode if I connect a controller to a charging laptop. |
@timrosu appended "feature", until one of the contributors or I get a chance to take a look at this. If you or anyone else wants to give it a try in implementing this functionality, please give it a try and contribute to the project and you will be credited for your work as part of future release. |
so my idea to fix this is to add an section the the config file where you can ignore specified batteries however then all will be included by default. is this the way this should be inplmented or wanted? or should we just hard code to ingore /sys/class/power_supply/gip* ? |
@PurpleWazard I think it would be best to add option to add batteries to ignore in config file and then show this option in readme. Names of problematic batteries could be included by default in conf file and ignoring enabled. |
@timrosu I submitted a PR wanna try it out |
@PurpleWazard Great. It works. |
@AdnanHodzic I think it's good as it is (apart from spelling mistake in config comment). |
* added the abilty to ignore certain power supplies * changed config file for ignoring power supplies * updated exapmle config file for ignoring power supplies * updated docs with ignoring power supplies * Update README.md Update image URL's * Add support for setting "Platform Profile" (#752) * Add support for setting "Platform Profile" * Add reference for Platform Profile * Fix unsafe access to PATH (#756) * Fix unsafe access to PATH * Fix leading separator if PATH is empty * Unpin psutil and requests (#759) * Remove network-online.target as a systemd-service dependency (improve boot time). Closes: #739 * minor grammer correction. * removed wonky file --------- Co-authored-by: Adnan Hodzic <adnan@hodzic.org> Co-authored-by: Harsh Panchal <BOOTMGR@users.noreply.github.com> Co-authored-by: BowDown097 <42720004+BowDown097@users.noreply.github.com> Co-authored-by: shadeyg56 <31134255+shadeyg56@users.noreply.github.com>
Fill out information requested in this template, without doing so issue will be ignored & closed!
Have you tried?
Error output:
System information:
Add/paste output of:
Also please be descriptive about the issue you're reporting, i.e: what you tried & what's the expected behaviour.
Few months ago I have copied default config from readme to my conf file on my desktop pc and only changed turboboost to always. I was playing games in Windows vm with xbox wireless adapter passed to it back then.
Last week I tried gaming natively on Linux and installed xone driver (xone-dkms in aur) which reports battery level of controller. I then tried playing FS22 (pretty CPU intensive) and it worked great (90-130 fps)... until I connected controller and fps dropped to 30. Then I tried connecting it with wire and it worked normally (because controller doesn't report battery usage when plugged). I noticed that cpu frequency was a bit low (800 MHz). Then I went to look at output of
auto-cpufreq status
and saw that it is using powersave governor and that (controller's) battery was discharging.In debug output I noticed that program detects computer type. Why doesn't it then just ignore the battery entry in config if desktop type is detected?
I tried connecting my motorcycle helmet intercom to pc and its battery wasn't detected in auto-cpufreq.
Then I looked into
/sys/class/power_supply
and found that xone has made an entry namedgip0.0
Contents of uevent to help you filter it out:
The text was updated successfully, but these errors were encountered: