WIP: Implement python virtual environment #263
Conversation
* added venv instead of using system env pip
* adjusted the unit file to startup the app from the venv
* created a wrapper script to call the app from the venv
* extended cleanup for venv and additional scripts
* refactored the is_running() function to find the process now that it
is called from a venv
aroundthfur
changed the title
|
Please do not merge yet! I am experiencing random SIGKILL on the process. Not sure why yet, it needs to be debugged more. |
|
Could it be that power-profiles-daemon had something to do with it at the time of testing this? |
@bobslept yep, that exactly was the reason as it was confirmed to me by @aroundthfur in private. Btw, whenever you have time /you're able feel free to push final updates to this PR. |
|
What would be the correct way of doing this. Merge his branch from the fork locally, work on it and push it as new PR and mention this PR in the new one? I can do it like that if you want. Not sure if it is the right way. |
Please do this. As I also got @aroundthfur consent to do this (make new PR on top of his changes) in the end I'll just credit you both. |
|
Changes live as part of v1.9.0 release. |
is called from a venv
I tested this on Fedora 35. It worked fine (TM).
Please test on other platforms before merging. I am especially not sure how this change reflects on SNAP and other packaging systems.