[BUG-FIX] Adding root_check before set_override method execution #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will ensure that set_override calls are always in su mode. So, in effect all override using 'force' can clearly access the governer_override_state path file, and write changes to it, without externally tinkering the environment.
|
Great catch! Thank you for your contribution, you'll be given credit for your work as part of upcoming release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes permission issue prompt when calling
--forceflag in non root mode.This PR, basically calls pre-defined
root_check()function before accessingset_overridemethod aimed at implementing the force feature.And hence ensuring
set_overridecalls are always in su mode.So, in effect all override using 'force' can clearly access the
governer_override_statepath file, and write changes to it, without externally tinkering the environment.Current output
Past output
Fixes #523