Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes auto-cpufreq --update for Arch based distros for non AUR installations #550

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

rootCircle
Copy link
Contributor

@rootCircle rootCircle commented Sep 9, 2023

Details:

  • Updated logic now checks if auto-cpufreq is installed via AUR or not (pacman -Q auto-cpufreq). If found, it recommends using the system package manager to refresh it.

  • Removed the obsolete yay checking as yay is considered a Pacman wrapper. (Need confirmation from @cosmos1721 for intent)

Fixes:
Persistant Arch-based distribution with AUR support detected. Please refresh auto-cpufreq using your AUR helper. error, even when you haven't installed auto-cpufreq from AUR, on Arch Distro.

References:
Arch Wiki - AUR Helpers

… installed from AUR or not! Changes also removal of yay checking as yay is pacman wrapper. https://wiki.archlinux.org/title/AUR_helpers
@shadeyg56
Copy link
Collaborator

Yeah, yay should never have been used in the first place as a lot of Arch systems don't even use it, while pacman is available on all Arch systems

@cosmos1721
Copy link
Contributor

  • Removed the obsolete yay checking as yay is considered a Pacman wrapper.

pls do, can you also look up other configurations that are done for Arch?

@AdnanHodzic
Copy link
Owner

AdnanHodzic commented Sep 10, 2023

Great one @rootCircle! Because I was proposing the same to @cosmos1721 as part of of the comments in original PR. But idea was that we'd wait for a PR like this one coming from Arch user :)

@AdnanHodzic AdnanHodzic merged commit e173723 into AdnanHodzic:master Sep 10, 2023
@rootCircle
Copy link
Contributor Author

rootCircle commented Sep 10, 2023

pls do, can you also look up other configurations that are done for Arch?

@cosmos1721
I could find references of arch checking in auto-cpufreq/gui/objects.py, auto-cpufreq-installer and auto-cpufreq/core.py. But, all their usage were safe in my opinion.

For now, I will wait for next release to test the update on Arch and will report, if it breaks. Rest all looks good to me ig:-)
Although, I have tried triggering an update event(editing setup.py) and was successful in installing also, but i need more surety regarding the same.

@rootCircle
Copy link
Contributor Author

Updated to v2.0.0, update seems to work fine on Arch based distros!

Congrats for the v2.x.x feat! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants