Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for pyproject.toml #576

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

rootCircle
Copy link
Contributor

@rootCircle rootCircle commented Oct 10, 2023

Initial Support for pyproject.toml

Changes

  • Support for pyproject as per PEP-518
  • setup.py renamed to setup.old.py

Needs help in checking if

  • Snap builds works
  • Nix build works

Couldn't Implement

  • python setup.py install --record equivalent in this case

Breaking Changes

  • Dynamic versioning is not the same as the one provided by pkg_marker, however appropriate apis in core.py has been provided in to fix that problem
    eg:
    Old Version Scheme : auto-cpufreq==2.0.0-e7dyadda
    New Version SCheme : auto-cpufreq-2.0.0-e7dyadda
    auto-cpufreq --version won't be affected by this however.

  • bin files have moved from bin/<exec> to auto-cpufreq/bin/<exec>.py

Tested

  • Installation works
  • auto-cpufreq --install works
  • GUI works

Running the project

  • git clone git@github:AdnanHodzic/auto-cpufreq.git
    cd auto-cpufreq
    poetry install
    poetry run auto-cpufreq --help
  • Alternatively, we can use editable pip install for development purposes

    git clone git@github:AdnanHodzic/auto-cpufreq.git
    cd auto-cpufreq
    # Setup  your Virtual Environment
    pip3 install -e .
    auto-cpufreq

@shadeyg56
Copy link
Collaborator

Awesome, I can test to see if it builds on Nix. Is there any point into hanging onto the setup.py?

@shadeyg56 shadeyg56 added enhancement New feature or request hacktoberfest labels Oct 10, 2023
@rootCircle
Copy link
Contributor Author

Awesome, I can test to see if it builds on Nix.

That would be great! 😄

Is there any point into hanging onto the setup.py?

No, I don't think so, I have just kept it for archival purpose, maybe we can remove it after proper testing is done......

@shadeyg56
Copy link
Collaborator

The Nix package needed some slight modifications to work, but I have pushed the changes to your branch to make it build on Nix!

@rootCircle
Copy link
Contributor Author

The Nix package needed some slight modifications to work, but I have pushed the changes to your branch to make it build on Nix!

Sounds great! Thanks 😄

@AdnanHodzic
Copy link
Owner

LGTM & thank you for your contibution!

Wondering if "Running the project" part should've been included anywhere into README? Also let's keep an eye if pip3 install . is not working on plethora of distros that auto-cpufreq that can be installed on nowdays :)

@AdnanHodzic AdnanHodzic merged commit 37e12a4 into AdnanHodzic:master Oct 13, 2023
@rootCircle
Copy link
Contributor Author

Wondering if "Running the project" part should've been included anywhere into README?

Sure, I can

Also let's keep an eye if pip3 install . is not working on plethora of distros that auto-cpufreq that can be installed on nowdays :)

How about replacing that with pip as fallback, if that doesn't works out?

@AdnanHodzic I wanted to tell that if this update breaks few things due to record files.txt in tool_remove in auto-cpufreq-installer, although I have tested if installation and removal things works or not!

shadeyg56 added a commit to shadeyg56/auto-cpufreq that referenced this pull request Feb 12, 2024
* feat: support for pyproject.toml

* Nix: Fix package to work with pyproject.toml

---------

Co-authored-by: shadeyg56 <shadeyg56@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants