Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring and fix for #14 (AMD issue) #62

Merged
merged 3 commits into from
Aug 4, 2020

Conversation

Red-Eyed
Copy link
Contributor

@Red-Eyed Red-Eyed commented Aug 3, 2020

  • A bit of refactoring
  • solves KeyError: 'coretemp' #14 As I didn't find how to get temperature for AMD Ryzen, I just display acpitz instead of core temp.

@AdnanHodzic
Copy link
Owner

This is great, thank you for your contribution!

Since it seems you have an AMD CPU and know your way around it. If you have time to look at #17 that would be great. As resolving this would basically add AMD support for auto-cpufreq which would be a huge contribution.

@AdnanHodzic AdnanHodzic merged commit 820b97c into AdnanHodzic:master Aug 4, 2020
@AdnanHodzic AdnanHodzic mentioned this pull request Aug 4, 2020
@Red-Eyed
Copy link
Contributor Author

Red-Eyed commented Aug 4, 2020

Yeah, I read about #17. But in my case , I have 2 governors: performance and powersafe.
It seems that some AMD CPUs don't have powersafe but schedutil instead.

BTW: I increased my bat life from 5h to 9h! it's very nice and helpful project, thank you for this!
Also, it's cool that it's written in python, because I'm a python dev and very love thins language, so glad to contribute :)

@AdnanHodzic
Copy link
Owner

Yeah, I read about #17. But in my case , I have 2 governors: performance and powersafe.
It seems that some AMD CPUs don't have powersafe but schedutil instead.

Weird, first thing that comes to mind is to make additional check which governors to use based on which AMD CPU is detected.

BTW: I increased my bat life from 5h to 9h! it's very nice and helpful project, thank you for this!

Most welcome, thank you as it's always great to hear feedback like this :)

Also, it's cool that it's written in python, because I'm a python dev and very love thins language, so glad to contribute :)

Great! In that case I hope I'll see more of your pull requests and I'll make sure to add your contributions in release notes of a new release.

AdnanHodzic pushed a commit that referenced this pull request Sep 2, 2020
* refactored and fixed amd coretemp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants