Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for AMD. More refactoring #63

Closed
wants to merge 15 commits into from

Conversation

Red-Eyed
Copy link
Contributor

@Red-Eyed Red-Eyed commented Aug 4, 2020

fixes #17

  • Added get_avail_powersave() (and performance).
      This function returns the most energy(and performance) efficient governor.
      This should fix AMD issue when powersave is not available
      but "ondemand" or "schedutil" are present

  • Cleaned up and refactored.
      Added more convenient util functions.
      Also made it more pythonic, reduced subprocess calls, made it more modular

  • Added support for setting turbo boost for AMD and Intel (intel_pstate and cpufreq driver)

  • Tested on Intel and AMD machines and it works fine

    • It at least doesn't fail
    • performance/powersave is
    • turbo is switching on high CPU load.
  • It needs more testing

- added get_avail_powersave() (and performance).
  This function returns the most energy efficient governor.
  This should fix AMD issue when powersave is not available
  but "ondemand" or "schedutil" are present

- Cleaned up and refactoring.
  Added more convinient util fuctions.
  Also made it more pythonic, reduced subprocess calls.

- tested on Intel machine and it works fine:
  It at least doesn't crash, turbo is switching on hight CPU load.

- It needs more testing
- fixed typo
- fixed get_curr_gov()
@Red-Eyed
Copy link
Contributor Author

Red-Eyed commented Aug 5, 2020

@AdnanHodzic please, don't review it. Just tried it on amd and have issues.

@Red-Eyed
Copy link
Contributor Author

Red-Eyed commented Aug 5, 2020

@AdnanHodzic now I tested it on AMD and fixed all related errors.
Didn't test snap version, as I have POP! OS

@Red-Eyed
Copy link
Contributor Author

Red-Eyed commented Aug 5, 2020

I would suggest to "squash merge" as I did a lot of garbage commits that should not be displayed in the master :)

@Red-Eyed Red-Eyed changed the title Fix #17 amd Added more suppoer for AMD. More refactoring Aug 5, 2020
@Red-Eyed Red-Eyed changed the title Added more suppoer for AMD. More refactoring Added support for AMD. More refactoring Aug 5, 2020
@AdnanHodzic
Copy link
Owner

I'll definitely squash it before merging, so no worries about how many commits you make :)

However, I have problem testing the changes:

git checkout -b "Red-Eyed-fix_\#17_amd" "master"
fatal: 'Red-Eyed-fix_\#17_amd' is not a valid branch name.
git checkout -b "Red-Eyed:fix_#17_amd" "master"
fatal: 'Red-Eyed:fix_#17_amd' is not a valid branch name.

Could you maybe change the branch name so it doesn't have # in it (which I think is the problem with bash)?

@Red-Eyed
Copy link
Contributor Author

Red-Eyed commented Aug 5, 2020

yep, 1 min

@Red-Eyed
Copy link
Contributor Author

Red-Eyed commented Aug 5, 2020

recreated #67

@Red-Eyed Red-Eyed closed this Aug 5, 2020
@Red-Eyed
Copy link
Contributor Author

Red-Eyed commented Aug 6, 2020

@AdnanHodzic thanks for mentioned me in Release Notes!
I would change description for AMD: acpitz -> k10temp

@AdnanHodzic
Copy link
Owner

@AdnanHodzic thanks for mentioned me in Release Notes!

Of course! I had to find a way to thank you for the effort you put into this release :)

I would change description for AMD: acpitz -> k10temp

Updated.

@fernando-inf
Copy link

fernando-inf commented Jul 24, 2024

Not function whit AMD V1605B:

`$ sudo auto-cpufreq --live

Note: You can quit live mode by pressing "ctrl+c"

----------------------------------- Warning -----------------------------------

Detected running GNOME Power Profiles daemon service!
This daemon might interfere with auto-cpufreq and has been disabled.

This daemon is not automatically disabled in "monitor" mode and
will be enabled after auto-cpufreq is removed.


------------------ Checking for necessary scaling governors -------------------

ERROR:

Couldn't find any of the necessary scaling governors.
`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Couldn't find any of the necessary scaling governors. AMD CPU possibly not supported?
3 participants