-
-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for AMD. More refactoring #63
Conversation
- added get_avail_powersave() (and performance). This function returns the most energy efficient governor. This should fix AMD issue when powersave is not available but "ondemand" or "schedutil" are present - Cleaned up and refactoring. Added more convinient util fuctions. Also made it more pythonic, reduced subprocess calls. - tested on Intel machine and it works fine: It at least doesn't crash, turbo is switching on hight CPU load. - It needs more testing
@AdnanHodzic please, don't review it. Just tried it on amd and have issues. |
@AdnanHodzic now I tested it on AMD and fixed all related errors. |
I would suggest to "squash merge" as I did a lot of garbage commits that should not be displayed in the master :) |
I'll definitely squash it before merging, so no worries about how many commits you make :) However, I have problem testing the changes:
Could you maybe change the branch name so it doesn't have |
yep, 1 min |
recreated #67 |
@AdnanHodzic thanks for mentioned me in Release Notes! |
Of course! I had to find a way to thank you for the effort you put into this release :)
Updated. |
Not function whit AMD V1605B: `$ sudo auto-cpufreq --live Note: You can quit live mode by pressing "ctrl+c" ----------------------------------- Warning ----------------------------------- Detected running GNOME Power Profiles daemon service! This daemon is not automatically disabled in "monitor" mode and ------------------ Checking for necessary scaling governors ------------------- ERROR: Couldn't find any of the necessary scaling governors. |
fixes #17
Added get_avail_powersave() (and performance).
This function returns the most energy(and performance) efficient governor.
This should fix AMD issue when powersave is not available
but "ondemand" or "schedutil" are present
Cleaned up and refactored.
Added more convenient util functions.
Also made it more pythonic, reduced subprocess calls, made it more modular
Added support for setting turbo boost for AMD and Intel (intel_pstate and cpufreq driver)
Tested on Intel and AMD machines and it works fine
It needs more testing