Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-667: Modify message when using amd-pstate-epp #674

Merged
merged 6 commits into from
Apr 9, 2024
Merged

gh-667: Modify message when using amd-pstate-epp #674

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f9e716a
gh-667: Modify message when using amd-pstate-epp
corona10 Apr 7, 2024
2e01f6d
Address code review
corona10 Apr 8, 2024
302c5d2
Address code review
corona10 Apr 8, 2024
5408c44
nit
corona10 Apr 8, 2024
860ec51
Update
corona10 Apr 9, 2024
3a4e8c5
fix typo
shadeyg56 Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions auto_cpufreq/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,13 +267,20 @@ def turbo(value: bool = None):
"""
p_state = Path("/sys/devices/system/cpu/intel_pstate/no_turbo")
cpufreq = Path("/sys/devices/system/cpu/cpufreq/boost")
amd_pstate = Path("/sys/devices/system/cpu/amd_pstate/status")

if p_state.exists():
inverse = True
f = p_state
elif cpufreq.exists():
f = cpufreq
inverse = False
elif amd_pstate.exists():
value = amd_pstate.read_text().strip()
if value == "active":
print("CPU turbo is controlled by amd-pstate-epp driver")
return False
# Should not reach here.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to raise error here, but not sure about this project convention :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because following code will require f, but f is None at this moment.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get what you're saying. Its true but since it never reaches there, it shouldn't matter, but I suppose for future proofing, we can unindent the return False

else:
print("Warning: CPU turbo is not available")
return False
Expand Down