Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spam error message when setting energy_performance_preference #680

Merged
merged 4 commits into from
May 6, 2024

Commits on Apr 20, 2024

  1. Fix spam error message when setting energy_performance_preference

    The 'intel_pstate' driver does not allow the EPP to be set to anything
    but 'performance' when the scaling governor is set to 'performance',
    previously auto-cpufreq when the scaling-governor was set to
    'performance' tried to set the EPP to 'balance-performance'
    which caused a spam of write error messages in journalctl in system
    with 'intel_pstate' drivers.
    This is an intended behavior, since according to the [kernel documentation](https://docs.kernel.org/admin-guide/pm/intel_pstate.html#hwp-performance)
    when HWP is enabled[(which is enabled by default during boot with supported processors)](https://docs.kernel.org/admin-guide/pm/intel_pstate.html#active-mode-with-hwp)
    and scaling governor is set to performance the processor’s internal
    P-state selection logic is expected to focus entirely on performance.
    And this will override the EPP setting and reject any value different from 0 (“performance”).
    This commit just changes the 'balance-performance' EPP preference in
    set_performance() to 'performance'. Which fixes the spam issue.
    FosRexx committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    7be043a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    828db0e View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. Comparing the content of the file

    intel_pstate/staus to make sure the condition only applies when "active"
    FosRexx committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    26285b7 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Configuration menu
    Copy the full SHA
    d8ddc6f View commit details
    Browse the repository at this point in the history