Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #715, #713, #634 issues #716

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Conversation

Angel-Karasu
Copy link
Contributor

@Angel-Karasu Angel-Karasu commented Jun 1, 2024

Closes #715 : Pipe can cause problem for python 3.9 or earlier
Closes #713 : Using getoutput instead read to bypass symbolic link problem
Closes #634 : Compatible with many arguments

@Angel-Karasu Angel-Karasu changed the title Remove | in type Fix some issues Jun 1, 2024
@AdnanHodzic
Copy link
Owner

@Angel-Karasu since description is not very descriptive, does this PR close/fix all of the mentioned issues? As by looking at code that's the impression I'm getting but wanted to confirm.

As in that case I'd suggest something like Closes: #YX. After PR is merged, then I would suggest you update all 3 issues with message like: "PR #716 is merged which should fix the issue, if problem persists, please feel free to re-open it" or something along those lines.

@Angel-Karasu
Copy link
Contributor Author

I've improved the description
I'll follow your suggestions after the PR merge

@AdnanHodzic AdnanHodzic changed the title Fix some issues Fix #715, #713, #634 issues Jun 7, 2024
@AdnanHodzic
Copy link
Owner

Thank you for your contribution, you will be credited for your work as part of future release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants