nix: add overlay; use best practices #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Due to the ci failing I updated the flake, seems you were running a pretty outdated nixpkgs input.
|
|
Awesome, I wasn't aware of most of that stuff so I appreciate this,
Yeah I mean I expect most people to just use |
|
Btw thanks a ton to you both for maintaining this flake! <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋 , been a while since I last checked up on this project.
Changes made:
lib.mdDocwith lib;they are advised against, see Tracking issue: remove overuses ofwith lib;NixOS/nixpkgs#208242.--replace->--replace-fail, using--replacewill warn you that its being removed and the safe choice is--replace-failsince if something ever changes the build will fail.