New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix check_conservation_mode() function in ideapad_laptop.py #766

Merged

AdnanHodzic merged 1 commit into AdnanHodzic:master from Geffo029:master

Aug 23, 2024

Contributor

Geffo029 commented Aug 23, 2024

Add .rstrip() to value = check_output(["cat", CONSERVATION_MODE_FILE], text=True) to prevent new line character \n breaking if statement


          Fix check_conservation_mode() function in ideapad_laptop.py

0e1a6f2

AdnanHodzic merged commit 7925c21 into AdnanHodzic:master

2 checks passed

Owner

AdnanHodzic commented Aug 23, 2024

LGTM! Thank you for your contribution, you will be credited for your work as part of future release.

Closes #750

AdnanHodzic mentioned this pull request

I think there's a syntax bug in original code regarding ideapad? #765

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet