Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webhooks intro page + changes for challenge enhancement #7

Merged
merged 6 commits into from
Oct 28, 2021

Conversation

shikhartanwar
Copy link
Contributor

Description

This PR makes the following changes:

  • Adds webhook intro page which was missed during migration it seems
  • Refactors runtime webhooks as another page (webhooks intro is the index page now)
  • Adds documentation for asynchronous validation for new challenge workflow

How Has This Been Tested?

npm run dev gives the following error so this could not be tested locally as mentioned in the README.md. This error comes in the main branch as well.
However, I have made sure that the markdown preview and links are correct.

npm run dev error

Screenshots (if appropriate):

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Shikhar Tanwar added 4 commits October 22, 2021 11:46
@shikhartanwar shikhartanwar self-assigned this Oct 22, 2021
@icaraps
Copy link
Contributor

icaraps commented Oct 22, 2021

These pages were moved in app-builder docs see AdobeDocs/app-builder#136
cc @sarahxxu @kgera to clarify

@icaraps
Copy link
Contributor

icaraps commented Oct 22, 2021

npm run dev gives the following error

Which node version are you using ? Please use v14.x (LTS) which supports optional chaining.

@shikhartanwar
Copy link
Contributor Author

These pages were moved in app-builder docs see AdobeDocs/project-firefly#136 cc @sarahxxu @kgera to clarify

IMHO, intro to webhooks is a critical page for events documentation as well. So, ideally it should coexist in both repositories unless I am missing some context here.

@shikhartanwar
Copy link
Contributor Author

npm run dev gives the following error

Which node version are you using ? Please use v14.x (LTS) which supports optional chaining.

v12.18.3. Will try with 14.x.
@icaraps: Shall we add this info in the README.md as well?

@icaraps
Copy link
Contributor

icaraps commented Oct 22, 2021

@shikhartanwar the readme mentions Node.js LTS as prerequisite https://github.com/adobe/aio-theme#getting-started

@shikhartanwar
Copy link
Contributor Author

@shikhartanwar the readme mentions Node.js LTS as prerequisite https://github.com/adobe/aio-theme#getting-started

Thank you @icaraps. Changing to Node v14.x worked.

Quick question: Is it possible to have another level of indentation for the side bar on the right?

sidebar

Copy link
Contributor

@kgera kgera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we haven't changed branding from I/O to IO anywhere. So, lets continue the same way. Rest all good.

@kgera kgera merged commit 35c2a7b into AdobeDocs:main Oct 28, 2021
@icaraps
Copy link
Contributor

icaraps commented Oct 28, 2021

@shikhartanwar

Is it possible to have another level of indentation for the side bar on the right?

No it's currently max 2 levels only per design.

@shikhartanwar shikhartanwar deleted the challenge-enhancement branch November 1, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants