Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added instructions on magneto-coding-standard execution and configuration for PHPStorm #48

Merged

Conversation

sivaschenko
Copy link
Contributor

Purpose of this pull request

Added instructions on magneto-coding-standard execution and configuration for PHPStorm

Affected pages

@jeff-matthews jeff-matthews self-assigned this Aug 24, 2022
@jeff-matthews jeff-matthews added the major-update Significant original updates to existing content label Aug 24, 2022
@jeff-matthews jeff-matthews self-requested a review August 24, 2022 16:33
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @sivaschenko! Please see editorial suggestions.

src/pages/coding-standards/index.md Outdated Show resolved Hide resolved
src/pages/coding-standards/index.md Outdated Show resolved Hide resolved
src/pages/coding-standards/index.md Outdated Show resolved Hide resolved
src/pages/coding-standards/index.md Outdated Show resolved Hide resolved
src/pages/coding-standards/index.md Outdated Show resolved Hide resolved
src/pages/coding-standards/index.md Outdated Show resolved Hide resolved
src/pages/coding-standards/index.md Outdated Show resolved Hide resolved
@jeff-matthews jeff-matthews added the internal Differentiates work between external and internal contributors label Aug 24, 2022
Co-authored-by: Jeff Matthews <matthews.jeffery@gmail.com>
auto-merge was automatically disabled August 24, 2022 18:17

Head branch was pushed to by a user without write access

@sivaschenko
Copy link
Contributor Author

Thanks for the review @jeff-matthews ! Suggestions are applied.

@jeff-matthews jeff-matthews merged commit 64eb3b1 into AdobeDocs:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Differentiates work between external and internal contributors major-update Significant original updates to existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants