Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACP2E-2119: update documentation with new added attribute and examples. #196

Merged
merged 8 commits into from
Mar 26, 2024

Conversation

@alzota
Copy link
Contributor Author

alzota commented Sep 1, 2023

@keharper not sure about the Adobe CLA check ... I tried to sign it again not sure if I need to do something else or reach out to someone. Tried to sent an email to grp-opensourceoffice@adobe.com as recommended but the email doesn't exist anymore. Also show an issue reported regarding this adobe/cla-bot#157

@alzota
Copy link
Contributor Author

alzota commented Sep 1, 2023

@keharper I have done a rebase to the 2.4.7-develop branch. Also Cristian Partica proposed and approved these new changes which are backward compatible with existing functionality. Not sure if you have access to this ticket for more details: https://jira.corp.adobe.com/browse/ACP2E-2119?focusedCommentId=37623125&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-37623125

@jeff-matthews jeff-matthews added internal Differentiates work between community and Adobe staff 2.4.7 labels Sep 1, 2023
@jeff-matthews jeff-matthews added the major-update Significant updates to content label Sep 1, 2023
@alzota alzota closed this Sep 6, 2023
@alzota alzota reopened this Sep 6, 2023
@alzota
Copy link
Contributor Author

alzota commented Sep 7, 2023

I will need to make some changes to the documentation, but will come back once I do the code changes as well.

@alzota alzota marked this pull request as draft September 11, 2023 09:12
@@ -81,11 +81,12 @@ Attribute | Data type | Description

#### FilterMatchTypeInput attributes

Use the `FilterMatchTypeInput` object to construct a filter that returns products that partially fuzzy match a string or contain the specified pattern.
Use the `FilterMatchTypeInput` object to construct a filter that returns products that partially match a string or contain the specified pattern.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the "fuzzy" term as in opensearch / elasticsearch fuzziness is actually an additional param that in magento is not set or used and will return matches like "box" when searching for "fox".

https://opensearch.org/docs/latest/query-dsl/term/fuzzy/

@jeff-matthews
Copy link
Contributor

Hi @alzota,

Just checking to see if this should be merged for the 2.4.7-beta2 release. Let me know 😄

@keharper
Copy link
Contributor

@jeff-matthews The code PR is still in draft state.

@alzota
Copy link
Contributor Author

alzota commented Sep 28, 2023

@keharper @jeff-matthews please ignore the fact that code PR is in draft (is kept like this to avoid accidental merge to local team branch), it matters only once it get merged to mainline, so most likely will be version 2.4.7-beta3. Please let me know if I need to redo this PR against a new branch.

@keharper keharper marked this pull request as ready for review March 26, 2024 19:53
@keharper keharper merged commit 9033752 into AdobeDocs:2.4.7-develop Mar 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.4.7 internal Differentiates work between community and Adobe staff major-update Significant updates to content
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants