Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch openapispec files for indexing during prod deploy #37

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

dmitrymatio
Copy link
Contributor

@dmitrymatio dmitrymatio commented Jan 22, 2025

Description

This is a temporary fix for missing openapispec during indexing step of build process.

We expect to move away from this soon with the migration to EDS.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dmitrymatio dmitrymatio requested a review from jhodges10 January 22, 2025 19:12
Copy link
Collaborator

@jhodges10 jhodges10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this @dmitrymatio! This should solve our immediate issue blocking any indexing, and we'll revisit this in the future once we have an idea for how to index the actual contents of the API reference in more detail.

@jhodges10 jhodges10 merged commit 922502e into main Jan 29, 2025
6 checks passed
@jhodges10 jhodges10 deleted the indexing-temp-fix branch January 29, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants