-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stop requiring mingw labels on Openj9 JDK8+11 builds #79
Conversation
Signed-off-by: Stewart X Addison <sxa@redhat.com>
Thank you for creating a pull request! |
run tests |
mingw is not required. OpenJ9 used to use mingw but switched to use clang ~Nov 2018. |
🟢 PR TESTER RESULT 🟢✅ All pipelines passed! ✅ |
Seems to have just been an oversight that this limitation wasn't removed at that time :-) Thanks for the confirmation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Since this passed the checks it should be fairly safe. I'll merge and kick off 8 and 11 pipelines and provide the links here - we can see where all the jobs end up :-) |
|
Fix sign_build after merge
Based on adoptium/temurin-build#700 and the checks in #66 (comment) I think the tags are historic and no longer necessary as all bulid machines are set up the same way and the OpenJ9 builds no longer require special treatment (In fact 15+ do not have this tag).
@pshipton I presume you are not aware of any reason to keep
mingw
labels on the OpenJ9 builds to tie it to the IBM Cloud (SoftLayer) build machines we have?Signed-off-by: Stewart X Addison sxa@redhat.com