-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Determine whether OpenJ9 builds still need the mingw-cygwin
label
#66
Comments
mingw-cygwin
tagmingw-cygwin
label
Have asked Haroon to confirm about the alibaba machine on Slack. Running builds on the azure machines now. |
As per @adamfarley's request, a fresh openj9 build on build-alibaba-win2012r2-x64-1 |
@Haroon-Khel Isn't that the same test you've already done that worked at adoptium/infrastructure#1818 (comment)? |
Yes, I mentioned that in the slack thread. Wouldnt hurt to run another one though; more recent |
The only other two windows machines we could run on (if we remove the mingw tag requirement) are the two azure machines. Here's a pair of jdk8 and jdk16 runs to check those: build-azure-win2012r2-x64-1 (JDK16) - https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk16/job/jdk16-windows-x64-hotspot/57/ |
Ok, results: Azure machines: Builds and tests are green. Edit: Alibaba test results:
Most seem to be "could not start process" problems. |
Presumably that was just with the build running on alibaba - the tests were still just running on whatever random machines they happened to land on? |
Yes. The Alibaba build was tested on test-ibmcloud-win2012r2-x64-1. |
Re-running the lang tests for the alibaba build on the machine that ran and passed the testing for the azure machines (which was, ironically, build-alibaba-win2012r2-x64-2). https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/7366/console |
Ok, those all passed. Looks to me like the sanity.openjdk tests can all pass on builds generated from the alibaba and azure machines, so the mingw label can be safely removed from the list of windows build requirements. @Haroon-Khel - Your thoughts? |
Add FIPS testing
All of our machines should be configured the same so the mingw-cygwin label locks it onto the
ibmcloud
systems unnecessarily (in theory). We should verify whether the openj9 builds will run elsewhere (I think @Haroon-Khel has probably already verified the alibaba windows boxes)The text was updated successfully, but these errors were encountered: