Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ILogParser allows Readers for processing now. #337

Merged
merged 1 commit into from
Jan 16, 2021

Conversation

renelink
Copy link
Contributor

Hi,
I'm currently writting an eclipse integration for jitwatch, so that java projects can be launched with jitwatch enabled like e.g. code coverage.

Therefore I made a little change that makes the API more flexible. E.g. to report progress when reading large input files by passing the ILogFileParser a Reader that is based on a ProgressInputStream.

I also introduced a default method that takes a File in the ILogFileParser for backward compatibility.

Feel free to write me if you have any questions.

Regards
René

This makes the API more flexible. E.g. one could pass in a Reader that
is based on a ProgressInputStream so that progress can be reported for
large input files.
@chriswhocodes chriswhocodes merged commit bb50980 into AdoptOpenJDK:master Jan 16, 2021
@chriswhocodes
Copy link
Member

Thanks @renelink this sounds interesting! Will you release this Eclipse integration publicly?

@renelink
Copy link
Contributor Author

I guess I will release it under EPL. But I think I will need 2 or 3 more month. Maybe a first version can be released earlier.

Here is a preview of the current work in progress.

image

@renelink
Copy link
Contributor Author

renelink commented Jun 8, 2021

I recently published the first version on https://jitclipse.io and the eclipse marketplace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants