Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metadata to tiff files #103

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

Antsalacia
Copy link
Contributor

Add id key from search catalog in tiff file metadata.

Closes #100

@AdrienWehrle
Copy link
Owner

Great thanks @Antsalacia ! Let's add some tests to check it works fine in different situations and we're good to go! 👍

@AdrienWehrle AdrienWehrle self-requested a review November 24, 2024 17:36
earthspy/earthspy.py Outdated Show resolved Hide resolved
@AdrienWehrle
Copy link
Owner

I think you've tested it on the example case given in the README, which is a perfect first step. However, this area is small, and split boxes are hence not used. Now we need to know how it behaves over larger areas where the ids of different split boxes are also included for a specific date.

Could you try with a bounding box like [-51.13, 68.99, -48.50, 69.42] and report how the metadata tags behave? As in, do you get one tag per split box? Or one per date?

Maybe try no more than two or three dates otherwise download will get expensive.

@Antsalacia
Copy link
Contributor Author

I've tested with the bounding box provided and still had 1 tag per date. Test was done on those range ["2019-08-03", "2019-08-05"]

@AdrienWehrle AdrienWehrle self-requested a review November 26, 2024 14:02
@AdrienWehrle AdrienWehrle merged commit f44ef66 into AdrienWehrle:main Nov 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to save catalog object
2 participants