Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support Connect #1090

Merged
merged 2 commits into from
Jul 6, 2023
Merged

feat: Support Connect #1090

merged 2 commits into from
Jul 6, 2023

Conversation

luispinto-commercetools
Copy link
Contributor

@luispinto-commercetools luispinto-commercetools commented Jun 14, 2023 •
edited
Loading

Description

  • Add connect.yaml file
  • Extension
    • Use env variable provided by Connect (CONNECT_SERVICE_URL) to setup CoCo extensions
    • extension/src/paymentHandler/payment-handler.js reduce function complexity in order to conform with connect certification pipeline
  • Notification
    • Use env variable provided by Connect (CONNECT_SERVICE_URL) to setup adyen webhook
  • Update dependencies with vulnerabilities
  • Update Docs

Limitations / Constraints

  • Currently in Connect do not support adyen webhook HMAC
  • For Connect user must provide port 8080 for Notification app

@luispinto-commercetools luispinto-commercetools force-pushed the luispinto/im-288_connect-support branch 5 times, most recently from 925a108 to 60a3736 Compare June 15, 2023 21:11
@luispinto-commercetools luispinto-commercetools marked this pull request as ready for review June 15, 2023 21:17
@luispinto-commercetools luispinto-commercetools force-pushed the luispinto/im-288_connect-support branch 2 times, most recently from d24b7c3 to d2a544e Compare June 19, 2023 13:34
@luispinto-commercetools luispinto-commercetools force-pushed the luispinto/im-288_connect-support branch 2 times, most recently from 877d1b9 to 922574a Compare July 3, 2023 14:49
@leungkinghin-ct leungkinghin-ct merged commit 40251c8 into master Jul 6, 2023
@leungkinghin-ct leungkinghin-ct deleted the luispinto/im-288_connect-support branch July 6, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prateek-ct prateek-ct prateek-ct approved these changes

@praveenkumarct praveenkumarct praveenkumarct approved these changes

@leungkinghin-ct leungkinghin-ct leungkinghin-ct approved these changes

@lojzatran lojzatran Awaiting requested review from lojzatran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luispinto-commercetools @leungkinghin-ct @praveenkumarct @prateek-ct