-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix certification failure for Commercetools Connect #1103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to run Integration and e2e tests completely in the main branch?
I think still there are other users using this repo.
May you could consider ignoring only those tests which are failing at the moment. We can fix them later(Try to create a issue for our reference).
I misunderstood the changes, Yes the code looks good for me. |
The change in this PR would not affect the integration test and e2e test in CI/CD. Since Commercetools Connect does not get the adyen config from env-var during build, that's why we split those existing npm commands ( |
devDependencies
inpackage.json
as it uses vulnerable dependenciesnpm run test
command for Commercetools Connect, and executenpm run test-ci
in Github Action