Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix certification failure for Commercetools Connect #1103

Merged
merged 8 commits into from
Jul 28, 2023

Conversation

leungkinghin-ct
Copy link
Collaborator

@leungkinghin-ct leungkinghin-ct commented Jul 26, 2023

  • Move c8 to devDependencies in package.json as it uses vulnerable dependencies
  • Exclude integration test and e2e test from npm run test command for Commercetools Connect, and execute npm run test-ci in Github Action
  • Use mock config in notification module unit test
  • Update documentation

Copy link
Collaborator

@praveenkumarct praveenkumarct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to run Integration and e2e tests completely in the main branch?

I think still there are other users using this repo.
May you could consider ignoring only those tests which are failing at the moment. We can fix them later(Try to create a issue for our reference).

@praveenkumarct
Copy link
Collaborator

You don't need to run Integration and e2e tests completely in the main branch?

I think still there are other users using this repo. May you could consider ignoring only those tests which are failing at the moment. We can fix them later(Try to create a issue for our reference).

I misunderstood the changes, Yes the code looks good for me.

@leungkinghin-ct
Copy link
Collaborator Author

leungkinghin-ct commented Jul 28, 2023

You don't need to run Integration and e2e tests completely in the main branch?

I think still there are other users using this repo. May you could consider ignoring only those tests which are failing at the moment. We can fix them later(Try to create a issue for our reference).

The change in this PR would not affect the integration test and e2e test in CI/CD. Since Commercetools Connect does not get the adyen config from env-var during build, that's why we split those existing npm commands (npm run test is now dedicated for Commercetools Connect and execute unit test only).

@leungkinghin-ct leungkinghin-ct merged commit 02002de into master Jul 28, 2023
5 checks passed
@leungkinghin-ct leungkinghin-ct deleted the fix-connect-certification-failure branch July 28, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants