Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate TerminalLocalAPIUnencrypted.java #1412

Merged
merged 4 commits into from
Dec 23, 2024
Merged

Deprecate TerminalLocalAPIUnencrypted.java #1412

merged 4 commits into from
Dec 23, 2024

Conversation

ayodejidev
Copy link
Contributor

@ayodejidev ayodejidev commented Dec 22, 2024 •
edited
Loading

Description

This PR:

  • Adds a deprecation note to TerminalLocalAPIUnencrypted class
  • Provided a developer guide on how to use the local terminal API without encryption in the README
  • Refactor tables in the README

@ayodejidev ayodejidev requested a review from a team as a code owner December 22, 2024 19:30
@ayodejidev ayodejidev force-pushed the fix/deprecate-TerminalLocalAPIUnencrypted branch from 0ac52c7 to bc689c0 Compare December 22, 2024 19:39
gcatanese
gcatanese previously approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@gcatanese gcatanese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, approved but I have added few suggestions

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@DjoykeAbyah DjoykeAbyah merged commit c04157e into main Dec 23, 2024
6 checks passed
@AdyenAutomationBot AdyenAutomationBot mentioned this pull request Dec 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DjoykeAbyah DjoykeAbyah DjoykeAbyah approved these changes

@gcatanese gcatanese gcatanese left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayodejidev @gcatanese @DjoykeAbyah