refunds not implemented #25

Cornoud · 2016-03-29T13:39:51Z

Refunds initiated from Adyen are not implemented. Code is quoted.
Also when buildign this function emailing the credit email to the customer should NOT be depending on orderupdate email setting but on a seperate setting (allow sent refund emails)

rikterbeek · 2016-03-30T07:09:51Z

Hi Cornoud,

Refunds are implemented and not quoted. See here:
https://github.com/Adyen/adyen-magento2/blob/develop/Model/Method/Cc.php#L357-L372

We do not send email for a credit memo this is native Magento functionality.

Regards,
Rik
Adyen

Cornoud · 2016-03-30T09:06:43Z

Hi Rik,

Within https://github.com/Adyen/adyen-magento2/blob/master/Model/Cron.php the function _refundOrder is quoted.
Also the refund is only emailed when send_update_email is enabled. This setting is also used for other emails within Adyen module which in most cases are not desired to be sent to the customer.

[cid:image001.png@01D18A74.36ECC0E0]

Kind regards,

Cornoud

From: Rik ter Beek [mailto:notifications@github.com]
Sent: Wednesday, March 30, 2016 9:10 AM
To: Adyen/adyen-magento2
Cc: Cornoud van Sprundel
Subject: Re: [Adyen/adyen-magento2] refunds not implemented (#25)

Hi Cornoud,

Refunds are implemented and not quoted. See here:
https://github.com/Adyen/adyen-magento2/blob/develop/Model/Method/Cc.php#L357-L372

We do not send email for a credit memo this is native Magento functionality.

Regards,
Rik
Adyen

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHubhttps://github.com//issues/25#issuecomment-203283264

Cornoud · 2016-03-30T09:10:13Z

Hi Rik,

When will the master branch be updated with the latest fixes?

Kind regards,

Cornoud

rikterbeek · 2016-03-30T09:21:20Z

Hi Cornoud,

This is because you need to do the refund from inside Magento.
If you do an online credit memo in magento it will automatically do a refund call to our platform.

Regards,
Rik
Adyen

rikterbeek · 2016-03-30T09:43:46Z

Hi Cornoud,

the send_update_email is not a setting from us and if I look into code from Magento2 the setting is absolute. https://github.com/magento/magento2/blob/develop/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_methods.php#L1764

Regards,
Rik
Adyen

Cornoud · 2016-03-30T11:30:46Z

Hi Rik,

So support for refunds made in Adyen is dropped in M2?

Not all customers will do the refund from Magento.
Some of our customers do the refund from Adyen.

Kind regards.

Cornoud

From: Rik ter Beek [mailto:notifications@github.com]
Sent: Wednesday, March 30, 2016 11:21 AM
To: Adyen/adyen-magento2
Cc: Cornoud van Sprundel
Subject: Re: [Adyen/adyen-magento2] refunds not implemented (#25)

Hi Cornoud,

This is because you need to do the refund from inside Magento.
If you do an online credit memo in magento it will automatically do a refund call to our platform.

Regards,
Rik
Adyen

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHubhttps://github.com//issues/25#issuecomment-203341672

rikterbeek · 2016-03-30T11:41:45Z

Hi Cornoud,

Why is it not done through Magento ? In Adyen partial refund is going to be diffecult to do because you do not know what items are refunded. For M1 we get the questions from merchants asking to not update magento if you do a refund on Adyen so that is why it is not included.

Regards,
Rik
Adyen

Cornoud · 2016-03-30T11:49:01Z

Hi Rick,

I do agree the best solution is thru magento, this what I advise to all my customers.
But I still do not like removing functionality which is present in most/all PSP implementations.

About 30% of ISM customers is still creating the refund in Adyen backoffice.
And using Magento for sending the credit email.
Reason for doing this in Adyen

     Fulfillment such as shipments and credits within Magento,

```
     Direct link between ERP and Adyen
```

     Manual processing by Financial employee without access to Magento

Kind regards,

Cornoud

From: Rik ter Beek [mailto:notifications@github.com]
Sent: Wednesday, March 30, 2016 13:42 PM
To: Adyen/adyen-magento2
Cc: Cornoud van Sprundel
Subject: Re: [Adyen/adyen-magento2] refunds not implemented (#25)

Hi Cornoud,

Why is it not done through Magento ? In Adyen partial refund is going to be diffecult to do because you do not know what items are refunded. For M1 we get the questions from merchants asking to not update magento if you do a refund on Adyen so that is why it is not included.

Regards,
Rik
Adyen

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHubhttps://github.com//issues/25#issuecomment-203391439

rikterbeek · 2016-03-30T12:19:35Z

Hi Cornoud,

Let me have a look this week it should not be hard to implement.

Regards,
Rik
Adyen

rikterbeek · 2016-03-31T11:43:23Z

Hi Cornoud,

It is difficult to realize this because of the protected function they have introduced for prepareCreditMemo. There is a method called registerRefundNotification that is public but there is a bug in this call see: magento/magento2#2656

Regards,
Rik
Adyen

Cornoud · 2016-03-31T12:53:19Z

Hi Rik,

I would suggest not building the functionality for the moment.

Thx,

Cornoud

From: Rik ter Beek [mailto:notifications@github.com]
Sent: Thursday, March 31, 2016 13:43 PM
To: Adyen/adyen-magento2
Cc: Cornoud van Sprundel
Subject: Re: [Adyen/adyen-magento2] refunds not implemented (#25)

Hi Cornoud,

It is diffecult to realize this because of the protected function they have introduced for prepareCreditMemo. There is a method called registerRefundNotification that is public but there is a bug in this call see: magento/magento2#2656 magento/magento2#2656

Regards,
Rik
Adyen

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHubhttps://github.com//issues/25#issuecomment-203893604

rikterbeek · 2016-04-01T07:50:50Z

Hi Cornoud,

We will wait until there is a proper solution available in magento2.

Regards,
Rik
Adyen

alessandroniciforo · 2017-06-14T11:41:29Z

@rikterbeek it looks like 2656 has been fixed. Maybe this issue can be solved now?

rikterbeek · 2017-06-28T06:11:04Z

Hi @alessandroniciforo,

Sorry for the late reply missed your comment. Thanks for letting us know. We highly advise you to do refunds directly form inside Magento because of extra functionality as option to put back in stock and partial refunds of particular products. Is there a reason why you can't use this inside Magento ?

Regards,
Rik
Adyen

alessandroniciforo · 2017-06-29T14:44:09Z

@rikterbeek at this stage, we're just exploring all the different functionalities and while trying to issue refunds from Adyen backend I stumbled upon this commented piece of code with the reference to issue #2656 on Magento, so I thought of updating this issue.
I think we should be fine doing it inside Magento.
Thanks,
Alessandro

dev-awevo mentioned this issue Dec 24, 2018

Cronjob notification error #366

Closed

cyattilakiss closed this as completed Jul 9, 2019

stutaylor mentioned this issue Jun 25, 2021

[PW-5016] Issue with getStreetAndHouseNumberFromAddress Not allowing checkout #1082

Closed

r-martins mentioned this issue Jul 6, 2021

Can't place order - TypeError: Argument 1 passed to Adyen\Payment\Helper\Address::getStreetAndHouseNumberFromAddress() must be an instance of Magento\Payment\Gateway\Data\AddressAdapterInterface #1093

Closed

dronerdk mentioned this issue Jul 4, 2022

[PW-6878] Capture webhook not working in 8.3.0 #1595

Closed

othuress mentioned this issue Apr 4, 2023

The order cannot be confirmed even though the notification arrives #610

Closed

othuress mentioned this issue Apr 13, 2023

[ECP-8518] New Implement option to use queue or cron causes error Unknown connection name amqp #2031

Closed

evs-xsarus mentioned this issue Jul 18, 2024

Property with dot in name can't be serialized #2682

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refunds not implemented #25

refunds not implemented #25

Cornoud commented Mar 29, 2016

rikterbeek commented Mar 30, 2016

Cornoud commented Mar 30, 2016

Cornoud commented Mar 30, 2016

rikterbeek commented Mar 30, 2016

rikterbeek commented Mar 30, 2016

Cornoud commented Mar 30, 2016

rikterbeek commented Mar 30, 2016

Cornoud commented Mar 30, 2016

rikterbeek commented Mar 30, 2016

rikterbeek commented Mar 31, 2016

Cornoud commented Mar 31, 2016

rikterbeek commented Apr 1, 2016

alessandroniciforo commented Jun 14, 2017

rikterbeek commented Jun 28, 2017

alessandroniciforo commented Jun 29, 2017

refunds not implemented #25

refunds not implemented #25

Comments

Cornoud commented Mar 29, 2016

rikterbeek commented Mar 30, 2016

Cornoud commented Mar 30, 2016

Cornoud commented Mar 30, 2016

rikterbeek commented Mar 30, 2016

rikterbeek commented Mar 30, 2016

Cornoud commented Mar 30, 2016

rikterbeek commented Mar 30, 2016

Cornoud commented Mar 30, 2016

rikterbeek commented Mar 30, 2016

rikterbeek commented Mar 31, 2016

Cornoud commented Mar 31, 2016

rikterbeek commented Apr 1, 2016

alessandroniciforo commented Jun 14, 2017

rikterbeek commented Jun 28, 2017

alessandroniciforo commented Jun 29, 2017