paypal diagram #1116
Open
paypal diagram #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amihajlovski
requested review from
maassenbas,
shanikantsingh and
zenit2001
as code owners
|
zenit2001
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
- The point 1 in Steps mentions 'apple pay'. It should be 'paypal'
- The Adyen-makeExpressPaymentsCall would happen before Adyen-ShippingMethonds and Adyen-SelectShippingMethods call
- The Adyen-ShippingMethonds and Adyen-SelectShippingMethods calls would also in turn call /paypal/updateOrder endpoint on Adyen
- the initializeCheckout would happen after paymentMethods call
There was a problem hiding this comment.
Thanks for the comment, I will apply these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Describe the changes proposed in this pull request:
Fixed issue: SFI-792