This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
Make SparkOfflineStore compatible with interface change in feast>=0.17 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update readme to reflect Adyen template and add code owners
* Add github actions workflow based on python-package.yaml example * Black format repository * Install dev requirements with workflow * Update setup.py to only include dev as extra requires * Install package with dev requirements in github action workflow * Remove support for python 3.7 * Add workflow to publish to Python on release Co-authored-by: thijsbrits <thijsbrits@users.noreply.github.com>
This reverts commit 0a92c8c.
First release with bumped version
Bump version to 0.0.4
ohommos
reviewed
Feb 24, 2022
| # interface of offline_utils.get_feature_view_query_context changed in feast==0.17 | ||
| arg_spec = inspect.getfullargspec(func=offline_utils.get_feature_view_query_context) | ||
| if "entity_df_timestamp_range" in arg_spec.args: | ||
| # for feast>=0.17 |
There was a problem hiding this comment.
I see we're trying to support across few versions; we should update requirements in setup.py to reflect that.
I't also be fine dropping support for older versions altogether. Users of this plugin can update it when updating feast in one-go.
There was a problem hiding this comment.
setup.py mentions feast>=0.15.0 which is correct. If we'd choose to not support backwards compatibility we would have to update the requirements.
I vote to keep it like this for now, this also allows us to decouple upgrading feast from upgrading feast-spark-offline-store
ohommos
reviewed
Feb 24, 2022
ohommos
reviewed
Feb 24, 2022
ohommos
reviewed
Feb 24, 2022
added 6 commits
February 24, 2022 15:16
jbvaningen
changed the title
thijsbrits
approved these changes
Feb 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SparkOfflineStorefunctionality to work withfeast>=0.17setuptools_scmfor versioningmainthat were not included in upstreamdevelopTested scenarios
Ran all tests
Fixed issue
#14