Mad rustc update #272
Merged
Mad rustc update #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nadrieril
force-pushed
the
mad-rustc-update
branch
from
3aedfd8
to
f11f64d
Compare
Nadrieril
commented
Jun 26, 2024
Nadrieril
commented
Jun 26, 2024
Nadrieril
force-pushed
the
mad-rustc-update
branch
3 times, most recently
from
7473e15
to
38f1141
Compare
Otherwise they don't have the right nightly.
Nadrieril
force-pushed
the
mad-rustc-update
branch
from
083eeca
to
326406c
Compare
This was referenced Jun 26, 2024
I also had to update cargo dependencies because of a nightly feature change that broke `ahash`.
Nadrieril
force-pushed
the
mad-rustc-update
branch
from
326406c
to
0fb1b5d
Compare
sonmarcho
reviewed
Jul 1, 2024
| @0 := const (true) | ||
| }, | ||
| 0 => { | ||
| @0 := const (false) | ||
| } |
There was a problem hiding this comment.
I'm surprised that the order changed here (case 1 then case 0)
There was a problem hiding this comment.
I think it changed in the MIR (and this is likely my doing again).
There was a problem hiding this comment.
Oh wait, that's code that we generate ourselves. We generate it in the order of the variants in the type definition, maybe that changed? That is weird.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR to hacspec/hax#735. This updates the rustc pin by about 8 months.
Closes #182.