Add precise filtering of which items to translate #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nadrieril
force-pushed
the
precise-opaques
branch
2 times, most recently
from
b0bc39a
to
62c0e8e
Compare
Nadrieril
force-pushed
the
precise-opaques
branch
from
62c0e8e
to
33539f6
Compare
sonmarcho
reviewed
Aug 20, 2024
sonmarcho
reviewed
Aug 20, 2024
| name: String, | ||
| generics: Vec<PatTy>, | ||
| /// For pretty-printing only: whether this is the name of a trait. | ||
| is_trait: bool, |
There was a problem hiding this comment.
It would make sense to also use it for matching I think.
For the Charon-ML side: we should have the same, but should also use it for matching (if true, we can only match a trait impl; if false then no restriction because we can use the syntax without impl ... for ... both for regular impls and trait impls).
There was a problem hiding this comment.
I'm not sure how useful that is: there cannot be a trait with the same name as a type
There was a problem hiding this comment.
Well, I guess with wildcards there can be 🤔
There was a problem hiding this comment.
Actually you're probably right: it may be useless. But I was mostly thinking about consistency/sanity...
|
It's super nice to finally have this, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a rust implementation of something like the
NameMatcher. This makes it possible to precisely filter items precisely, e.g. translate exactly one impl from the standard library. This fixes the issue of--extract-opaque-bodiestriggering a slurry of errors. This is still a bit rough but already useful.Fixes #214